From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] m28evk/mx28evk: fix nand_update_full
Date: Wed, 12 Dec 2012 04:05:06 +0100 [thread overview]
Message-ID: <201212120405.06766.marex@denx.de> (raw)
In-Reply-To: <1355268343.16025.2@snotra>
Dear Scott Wood,
> On 12/11/2012 03:36:21 PM, Eric B?nard wrote:
> > - since commit 418396e212b59bf907dbccad997ff50f7eb61b16 nand write.raw
> > can take the number of page to be written as an argument.
> > nand_update_full
> > is passing the size (in bytes) to nand write.raw. This value was
> > previously
> > ignored but now breaks the write.
> > - this patch updates the default environment of these boards to
> > provide a
> > pagecount instead of a size to nand write.raw.
> > - tested on a mx28evk with a 4k page NAND and on a custom board with a
> > 2k page NAND.
> >
> > Signed-off-by: Eric B?nard <eric@eukrea.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> >
> > include/configs/m28evk.h | 2 +-
> > include/configs/mx28evk.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Marek, can you ack this?
>
> There is still a change in behavior in that before
> 418396e212b59bf907dbccad997ff50f7eb61b16 it only wrote one page (since
> that's all the write.raw command ever did) but with this patch it will
> write ${fcb_sz} pages. I assume the new behavior is correct?
Yes, it's correct
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
prev parent reply other threads:[~2012-12-12 3:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 16:41 [U-Boot] [PATCH] m28evk/mx28evk: fix nand_update_full Eric Bénard
2012-12-10 16:49 ` Marek Vasut
2012-12-10 22:59 ` Scott Wood
2012-12-11 8:50 ` Eric Bénard
2012-12-11 17:10 ` Scott Wood
2012-12-11 21:36 ` [U-Boot] [PATCH v2] " Eric Bénard
2012-12-11 23:25 ` Scott Wood
2012-12-12 3:05 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212120405.06766.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.