All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Jack Mitchell <ml@communistcode.co.uk>,
	Ben Gamari <bgamari.foss@gmail.com>,
	linux-omap@vger.kernel.org,
	Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
Subject: Re: AM335x BeagleBone SPI Issues
Date: Wed, 12 Dec 2012 10:07:08 +0200	[thread overview]
Message-ID: <20121212080708.GA2440@arwen.pp.htv.fi> (raw)
In-Reply-To: <20121211175216.GA27012@arwen.pp.htv.fi>

[-- Attachment #1: Type: text/plain, Size: 2737 bytes --]

Hi,

On Tue, Dec 11, 2012 at 07:52:16PM +0200, Felipe Balbi wrote:
> Hi,
> 
> On Tue, Dec 11, 2012 at 07:03:14PM +0200, Felipe Balbi wrote:
> > Hi,
> > 
> > On Tue, Dec 11, 2012 at 04:24:52PM +0000, Jack Mitchell wrote:
> > > On 11/12/12 15:22, Ben Gamari wrote:
> > > >Jack Mitchell <ml@communistcode.co.uk> writes:
> > > >
> > > >>Shubhro, Felipe,
> > > >>
> > > >>Thank you, the reordering dma patch fixed the dma issue I was having!
> > > >>However, the bad news, I now get the same results for the dma and
> > > >>non-dma spidev test. While the scope shows the SPI clk and data is fine,
> > > >>the reading from the program still shows 0x00 for all words.
> > > >>
> > > >Just to make sure this has been thought of: I've seen this sort of
> > > >behavior in the past when the CLK pin wasn't configured as an input.
> > > >
> > > >Cheers,
> > > >
> > > >- Ben
> > > >
> > > 
> > > Ok, Ben, well spotted indeed! I changed the dtsi to use INPUT_PULLUP
> > > instead of OUTPUT_PULLUP and wallah!
> > > 
> > >   am3358_pinmux: pinmux@44e10800 {
> > >     spi0_pins: pinmux_spi0_pins {
> > >       pinctrl-single,pins = <
> > >         0x150 *0x30*      /* spi0_sclk.gpio0_2, INPUT_PULLUP | MODE0
> > > */<------------ changed to INPUT
> > >         0x154 0x30      /* spi0_d0.gpio0_3, INPUT_PULLUP | MODE0 */
> > >         0x158 0x10      /* spi0_d1.i2c1_sda, OUTPUT_PULLUP | MODE0 */
> > >         0x15c 0x10      /* spi0_cs0.i2c1_scl, OUTPUT_PULLUP | MODE0 */
> > >       >;
> > >     };
> > >     spi1_pins: pinmux_spi1_pins {
> > >       pinctrl-single,pins = <
> > >         0x190 *0x33*  /* mcasp0_aclkx.spi1_sclk, INPUT_PULLUP | MODE3
> > > */ <------------ changed to INPUT
> > >         0x194 0x33  /* mcasp0_fsx.spi1_d0, INPUT_PULLUP | MODE3 */
> > >         0x198 0x13  /* mcasp0_axr0.spi1_d1, OUTPUT_PULLUP | MODE3 */
> > >         0x19c 0x13  /* mcasp0_ahclkr.spi1_cs0, OUTPUT_PULLUP | MODE3 */
> > >       >;
> > >     };
> > 
> > funny, I did the same on my pandaboard and it still didn't work :-s
> > 
> > @@ -321,6 +322,10 @@ static struct omap_board_mux board_mux[] __initdata = {
> >         OMAP4_MUX(SDMMC5_DAT1, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
> >         OMAP4_MUX(SDMMC5_DAT2, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
> >         OMAP4_MUX(SDMMC5_DAT3, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
> > +
> > +       /* SPI1 */
> > +       OMAP4_MUX(MCSPI1_CLK, OMAP_MUX_MODE0 | OMAP_PIN_INPUT_PULLUP),
> 
> hehe, I'll reply to my own nonsense. Of course this won't work, I'm not
> muxing the other MCSPI pins :-p
> 
> I'll do that tomorrow and test, cheers

fyi, after muxing all lines correctly it works just fine on my panda.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-12-12  8:14 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10 13:23 AM335x BeagleBone SPI Issues Jack Mitchell
2012-12-10 13:53 ` Felipe Balbi
2012-12-10 14:50   ` Jack Mitchell
2012-12-10 14:59     ` Felipe Balbi
2012-12-10 15:19       ` Jack Mitchell
2012-12-10 15:26         ` Shubhrajyoti Datta
2012-12-10 16:18           ` Jack Mitchell
2012-12-10 18:35         ` Felipe Balbi
2012-12-11  6:39           ` Shubhrajyoti Datta
2012-12-11 10:17           ` Jack Mitchell
2012-12-11 10:20             ` Felipe Balbi
2012-12-11 10:38               ` Jack Mitchell
2012-12-11 11:48                 ` Felipe Balbi
2012-12-11 14:27                   ` Felipe Balbi
2012-12-11 15:23                     ` Jack Mitchell
2012-12-11 16:15                       ` Felipe Balbi
2012-12-11 15:22             ` Ben Gamari
2012-12-11 16:24               ` Jack Mitchell
2012-12-11 16:36                 ` Jack Mitchell
2012-12-11 17:02                 ` Jack Mitchell
2013-01-04 14:46                   ` Jan Lübbe
2013-01-04 16:21                     ` Jack Mitchell
2013-01-04 16:36                       ` Jack Mitchell
2012-12-11 17:03                 ` Felipe Balbi
2012-12-11 17:52                   ` Felipe Balbi
2012-12-12  8:07                     ` Felipe Balbi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-12-10 13:17 Jack Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121212080708.GA2440@arwen.pp.htv.fi \
    --to=balbi@ti.com \
    --cc=bgamari.foss@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=ml@communistcode.co.uk \
    --cc=omaplinuxkernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.