Re: [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0

[Gleb Natapov <gleb@redhat.com>]

On Wed, Dec 12, 2012 at 01:05:12PM +0800, Yang Zhang wrote:
> From: Yang Zhang <yang.z.zhang@Intel.com>
> 
> This hack is wrong. The pin number of PIT is connected to
> 2 not 0. This means this hack never takes effect. So it is ok
> to remove it.
> 
> Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
Acked-by: Gleb Natapov <gleb@redhat.com>

> ---
>  virt/kvm/ioapic.c |    9 ---------
>  1 files changed, 0 insertions(+), 9 deletions(-)
> 
> diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
> index cfb7e4d..f3abbef 100644
> --- a/virt/kvm/ioapic.c
> +++ b/virt/kvm/ioapic.c
> @@ -179,15 +179,6 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int irq)
>  	irqe.level = 1;
>  	irqe.shorthand = 0;
>  
> -#ifdef CONFIG_X86
> -	/* Always delivery PIT interrupt to vcpu 0 */
> -	if (irq == 0) {
> -		irqe.dest_mode = 0; /* Physical mode. */
> -		/* need to read apic_id from apic regiest since
> -		 * it can be rewritten */
> -		irqe.dest_id = ioapic->kvm->bsp_vcpu_id;
> -	}
> -#endif
>  	return kvm_irq_delivery_to_apic(ioapic->kvm, NULL, &irqe);
>  }
>  
> -- 
> 1.7.1

--
			Gleb.