Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Dec 12, 2012 at 04:24:26PM +0100, Paolo Bonzini wrote:
> Il 12/12/2012 16:21, Michael S. Tsirkin ha scritto:
> > Thinking about it some more, I'd rather move this stuff
> > out of pci.h
> > 
> > For virtio, there's actually linux/virtio_ids.h
> > which defines VIRTIO_ID_NET etc. We should add that,
> > and have virtio just use it.
> > 
> > Doesn't ivshmem have a linux driver?
> 
> No, you use it with mmap of sysfs files.  The doorbell feature requires uio.
> 
> > When it lands upstream we'll be able to add it to pci_ids.h
> > meanwhile keeping a number in device .c seems fine as well.
> 
> I think the point was to avoid conflicts, but as long as docs/specs/ is
> kept in sync that's fine.

Right. We are not the final authority on device/vendor IDs anyway -
I am more worried about using the correct IDs for emulated devices.

> > I will do the virtio change I think - meanwhile
> > could you limit this patch to just the .txt change please?
> 
> Ok, will resend.
> 
> Paolo