diff for duplicates of <20121213094543.GA23446@arm.com> diff --git a/a/1.txt b/N1/1.txt index 7d04f4c..7d8aa3c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,47 +1,51 @@ On Thu, Dec 13, 2012 at 09:13:33AM +0000, Thierry Reding wrote: > Hi Andrew, -> +>=20 > I don't like iterator interfaces too much, but I can live with that. > Other than that the patch looks good to me and I'll try to work it into > my Tegra PCIe patch series. -> +>=20 > Just two minor comments below. -> +>=20 > > diff --git a/drivers/of/address.c b/drivers/of/address.c > [...] -> > @@ -421,7 +472,7 @@ u64 __of_translate_address(struct device_node *dev, const __be32 *in_addr, -> > goto bail; -> > bus = of_match_bus(parent); -> > -> > - /* Cound address cells & copy address locally */ -> > + /* Count address cells & copy address locally */ -> > bus->count_cells(dev, &na, &ns); -> > if (!OF_CHECK_COUNTS(na, ns)) { -> > printk(KERN_ERR "prom_parse: Bad cell count for %s\n", -> +> > @@ -421,7 +472,7 @@ u64 __of_translate_address(struct device_node *dev,= + const __be32 *in_addr, +> > =09=09goto bail; +> > =09bus =3D of_match_bus(parent); +> > =20 +> > -=09/* Cound address cells & copy address locally */ +> > +=09/* Count address cells & copy address locally */ +> > =09bus->count_cells(dev, &na, &ns); +> > =09if (!OF_CHECK_COUNTS(na, ns)) { +> > =09=09printk(KERN_ERR "prom_parse: Bad cell count for %s\n", +>=20 > This is really minor, but it should still go into a separate patch. -> +>=20 > > diff --git a/include/linux/of_address.h b/include/linux/of_address.h > > index 01b925a..4582b20 100644 > > --- a/include/linux/of_address.h > > +++ b/include/linux/of_address.h -> > @@ -26,6 +26,8 @@ static inline unsigned long pci_address_to_pio(phys_addr_t addr) { return -1; } +> > @@ -26,6 +26,8 @@ static inline unsigned long pci_address_to_pio(phys_a= +ddr_t addr) { return -1; } > > #define pci_address_to_pio pci_address_to_pio > > #endif -> > +> > =20 > > +const __be32 *of_pci_process_ranges(struct device_node *node, -> > + struct resource *res, const __be32 *from); +> > +=09=09=09=09 struct resource *res, const __be32 *from); > > #else /* CONFIG_OF_ADDRESS */ -> > static inline int of_address_to_resource(struct device_node *dev, int index, -> > struct resource *r) -> > @@ -48,6 +50,11 @@ static inline const u32 *of_get_address(struct device_node *dev, int index, +> > static inline int of_address_to_resource(struct device_node *dev, int = +index, +> > =09=09=09=09=09 struct resource *r) +> > @@ -48,6 +50,11 @@ static inline const u32 *of_get_address(struct devic= +e_node *dev, int index, > > { -> > return NULL; +> > =09return NULL; > > } > > +const __be32 *of_pci_process_ranges(struct device_node *node, -> +>=20 > There should be a blank line to separate the above two lines. -> +>=20 Thanks for the feedback. diff --git a/a/content_digest b/N1/content_digest index c83abeb..378b120 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,61 +4,63 @@ "Subject\0Re: [PATCH] pci: Provide support for parsing PCI DT ranges property\0" "Date\0Thu, 13 Dec 2012 09:45:43 +0000\0" "To\0Thierry Reding <thierry.reding@avionic-design.de>\0" - "Cc\0linux-pci@vger.kernel.org <linux-pci@vger.kernel.org>" - Grant Likely <grant.likely@secretlab.ca> - Michal Simek <monstr@monstr.eu> - Rob Herring <robherring2@gmail.com> + "Cc\0Michal Simek <monstr@monstr.eu>" + linux-pci@vger.kernel.org <linux-pci@vger.kernel.org> devicetree-discuss <devicetree-discuss@lists.ozlabs.org> + Liviu Dudau <Liviu.Dudau@arm.com> rob.herring@calxeda.com <rob.herring@calxeda.com> - linuxppc-dev <linuxppc-dev@lists.ozlabs.org> - Benjamin Herrenschmidt <benh@kernel.crashing.org> - " Liviu Dudau <Liviu.Dudau@arm.com>\0" + Rob Herring <robherring2@gmail.com> + " linuxppc-dev <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On Thu, Dec 13, 2012 at 09:13:33AM +0000, Thierry Reding wrote:\n" "> Hi Andrew,\n" - "> \n" + ">=20\n" "> I don't like iterator interfaces too much, but I can live with that.\n" "> Other than that the patch looks good to me and I'll try to work it into\n" "> my Tegra PCIe patch series.\n" - "> \n" + ">=20\n" "> Just two minor comments below.\n" - "> \n" + ">=20\n" "> > diff --git a/drivers/of/address.c b/drivers/of/address.c\n" "> [...]\n" - "> > @@ -421,7 +472,7 @@ u64 __of_translate_address(struct device_node *dev, const __be32 *in_addr,\n" - "> > \t\tgoto bail;\n" - "> > \tbus = of_match_bus(parent);\n" - "> > \n" - "> > -\t/* Cound address cells & copy address locally */\n" - "> > +\t/* Count address cells & copy address locally */\n" - "> > \tbus->count_cells(dev, &na, &ns);\n" - "> > \tif (!OF_CHECK_COUNTS(na, ns)) {\n" - "> > \t\tprintk(KERN_ERR \"prom_parse: Bad cell count for %s\\n\",\n" - "> \n" + "> > @@ -421,7 +472,7 @@ u64 __of_translate_address(struct device_node *dev,=\n" + " const __be32 *in_addr,\n" + "> > =09=09goto bail;\n" + "> > =09bus =3D of_match_bus(parent);\n" + "> > =20\n" + "> > -=09/* Cound address cells & copy address locally */\n" + "> > +=09/* Count address cells & copy address locally */\n" + "> > =09bus->count_cells(dev, &na, &ns);\n" + "> > =09if (!OF_CHECK_COUNTS(na, ns)) {\n" + "> > =09=09printk(KERN_ERR \"prom_parse: Bad cell count for %s\\n\",\n" + ">=20\n" "> This is really minor, but it should still go into a separate patch.\n" - "> \n" + ">=20\n" "> > diff --git a/include/linux/of_address.h b/include/linux/of_address.h\n" "> > index 01b925a..4582b20 100644\n" "> > --- a/include/linux/of_address.h\n" "> > +++ b/include/linux/of_address.h\n" - "> > @@ -26,6 +26,8 @@ static inline unsigned long pci_address_to_pio(phys_addr_t addr) { return -1; }\n" + "> > @@ -26,6 +26,8 @@ static inline unsigned long pci_address_to_pio(phys_a=\n" + "ddr_t addr) { return -1; }\n" "> > #define pci_address_to_pio pci_address_to_pio\n" "> > #endif\n" - "> > \n" + "> > =20\n" "> > +const __be32 *of_pci_process_ranges(struct device_node *node,\n" - "> > +\t\t\t\t struct resource *res, const __be32 *from);\n" + "> > +=09=09=09=09 struct resource *res, const __be32 *from);\n" "> > #else /* CONFIG_OF_ADDRESS */\n" - "> > static inline int of_address_to_resource(struct device_node *dev, int index,\n" - "> > \t\t\t\t\t struct resource *r)\n" - "> > @@ -48,6 +50,11 @@ static inline const u32 *of_get_address(struct device_node *dev, int index,\n" + "> > static inline int of_address_to_resource(struct device_node *dev, int =\n" + "index,\n" + "> > =09=09=09=09=09 struct resource *r)\n" + "> > @@ -48,6 +50,11 @@ static inline const u32 *of_get_address(struct devic=\n" + "e_node *dev, int index,\n" "> > {\n" - "> > \treturn NULL;\n" + "> > =09return NULL;\n" "> > }\n" "> > +const __be32 *of_pci_process_ranges(struct device_node *node,\n" - "> \n" + ">=20\n" "> There should be a blank line to separate the above two lines.\n" - "> \n" + ">=20\n" "\n" "Thanks for the feedback.\n" "\n" @@ -67,4 +69,4 @@ "\n" Andrew Murray -46204637def1cc796412092b74b5d3c068001366346b1f5992267cc771fb8d00 +681eca1dc92454b6152a7de347c4eb927d3fce582686393482b0ad2980df1192
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.