From: Guenter Roeck <groeck-dsl@sbcglobal.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] ITE it8603e
Date: Thu, 13 Dec 2012 16:07:54 +0000 [thread overview]
Message-ID: <20121213160754.GA23032@roeck-us.net> (raw)
In-Reply-To: <CAC-0Eqii0d94mPbn=8MoOn9UMP_srC3s5Dt3q45G+GTdo2kptw@mail.gmail.com>
On Thu, Dec 13, 2012 at 01:00:30AM -0700, David Hubbard wrote:
> I'd like to send the same patch again but add signed-off-by this time :) I
> apologize.
>
> * * * * *
>
> Add experimental support for the it8603e chip (Asus f2a85-m motherboard)
> Write only tested for pwmN and pwmN_enable.
> Read tested, but the following appear broken:
> alarms
> fanN_alarm
> inN_alarm
> inN_max
> inN_min
> intrusionN_alarm
> pwmN_auto_channels_temp
> pwmN_freq
I don't think it is a good idea to report attributes which "appear to be
broken". At least for the voltage limits and the alarms it should be relatively
easy to find out if they work/don't work. Whatever doesn't work should not be
there.
> temp3_input (there is no 3rd analog temp input to the chip)
>
Other IT87xx chips report the AMDSTI/PCH temperature as one of the inputs. This
is usually configurable.
Another question is to what extend we can depend on the logic in it87_find() to
detect enabled chip features. It might make more sense to create another if case
in that function to handle the IT8603 separately.
Can you improve superiotool to display the chip's registers, and/or create a
manual register dump ? Maybe that would help identifying some of the missing
pieces.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-12-13 16:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 20:41 [lm-sensors] ITE it8603e David Hubbard
2012-11-29 5:05 ` Guenter Roeck
2012-11-29 10:09 ` David Hubbard
2012-11-29 11:48 ` Jean Delvare
2012-11-29 18:00 ` David Hubbard
2012-12-02 17:57 ` Jean Delvare
2012-12-02 18:26 ` Guenter Roeck
2012-12-02 18:52 ` Jean Delvare
2012-12-02 19:20 ` Guenter Roeck
2012-12-03 8:44 ` Jean Delvare
2012-12-03 8:56 ` Rudolf Marek
2012-12-03 14:35 ` Guenter Roeck
2012-12-12 14:45 ` Jean Delvare
2012-12-13 7:58 ` David Hubbard
2012-12-13 8:00 ` David Hubbard
2012-12-13 16:07 ` Guenter Roeck [this message]
2012-12-13 21:27 ` David Hubbard
2012-12-13 22:13 ` Guenter Roeck
2012-12-13 22:40 ` David Hubbard
2012-12-16 10:15 ` Jean Delvare
2012-12-16 16:54 ` Guenter Roeck
2013-11-12 13:48 ` Rudolf Marek
2013-11-13 4:23 ` Guenter Roeck
2013-11-16 11:19 ` Rudolf Marek
2013-11-16 15:02 ` Guenter Roeck
2013-11-19 7:50 ` Rudolf Marek
2013-11-19 16:29 ` Guenter Roeck
2013-11-22 12:42 ` Jean Delvare
2013-11-22 21:51 ` Rudolf Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213160754.GA23032@roeck-us.net \
--to=groeck-dsl@sbcglobal.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.