From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <shemminger@vyatta.com>
Date: Thu, 13 Dec 2012 16:23:46 -0800
From: Stephen Hemminger <shemminger@vyatta.com>
Message-ID: <20121213162346.71c3779f@nehalam.linuxnetplumber.net>
In-Reply-To: <50CA7078.8070204@sfc.wide.ad.jp>
References: <50CA6DA5.1020101@sfc.wide.ad.jp>
	<20121213161201.6d2da433@nehalam.linuxnetplumber.net>
	<50CA7078.8070204@sfc.wide.ad.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Bridge] [PATCH] bridge: Bug fix for incorrect interpretation
 of MLDv2 maximum response code
List-Id: Linux Ethernet Bridging <bridge.lists.linux-foundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bridge>, 
	<mailto:bridge-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bridge/>
List-Post: <mailto:bridge@lists.linux-foundation.org>
List-Help: <mailto:bridge-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bridge>,
	<mailto:bridge-request@lists.linux-foundation.org?subject=subscribe>
To: Ang Way Chuang <wcang@sfc.wide.ad.jp>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org

On Fri, 14 Dec 2012 08:19:04 +0800
Ang Way Chuang <wcang@sfc.wide.ad.jp> wrote:

> On 14/12/2012 08:12, Stephen Hemminger wrote:
> > On Fri, 14 Dec 2012 08:07:01 +0800
> > Ang Way Chuang <wcang@sfc.wide.ad.jp> wrote:
> >
> >> This patch fixes the incorrect interpretation of endianness of MLDv2 maximum response
> >> code within bridge's multicast snooping code.
> >>
> >> Signed-off-by: Ang Way Chuang <wcang@sfc.wide.ad.jp>
> >> ---
> >> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> >> index 977c3ee..29c6283 100644
> >> --- a/net/bridge/br_multicast.c
> >> +++ b/net/bridge/br_multicast.c
> >> @@ -1172,7 +1172,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
> >>  		mld2q = (struct mld2_query *)icmp6_hdr(skb);
> >>  		if (!mld2q->mld2q_nsrcs)
> >>  			group = &mld2q->mld2q_mca;
> >> -		max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(mld2q->mld2q_mrc) : 1;
> >> +		max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(ntohs(mld2q->mld2q_mrc)) : 1;
> >>  	}
> >>  
> >>  	if (!group)
> > Already fixed as part of my patch to fix sparse warnings.
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> aye, aye.

Yours looks cleaner (I added a temp variable). You might want to submit
patch to switch to your oneline version.