From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Ahern <dsahern@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] perf changes for v3.8
Date: Thu, 13 Dec 2012 17:59:04 +0100 [thread overview]
Message-ID: <20121213165904.GA18574@gmail.com> (raw)
In-Reply-To: <CA+55aFyZ2kAQPmZSv_sfHDAR1gusOxO22TRX-kqSim-cZrMscw@mail.gmail.com>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > I could write the patch to completely invert the
> > exclude_guest logic -- make it include_guest. That breaks
> > all existing perf binaries as well - just a different syntax
> > that gets broken. That regression is acceptable?
>
> It's not a regression since THAT CODE NEVER WORKED, for
> chissake! The case of people actually profiling into virtual
> machines crashes the running VMs, as you say. There's no way
> in hell we can call it a regression to say "you now have to
> use a flag if you profile a load with virtualization", since
> there wasn't any working case to begin with.
Correct.
::include_guest looks like the more logical flag direction to
use in any case.
Thanks,
Ingo
next prev parent reply other threads:[~2012-12-13 16:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 9:09 [GIT PULL] perf changes for v3.8 Ingo Molnar
2012-12-13 2:53 ` Linus Torvalds
2012-12-13 3:02 ` David Ahern
2012-12-13 3:09 ` Linus Torvalds
2012-12-13 3:16 ` David Ahern
2012-12-13 3:25 ` David Ahern
2012-12-13 3:34 ` Linus Torvalds
2012-12-13 3:43 ` David Ahern
2012-12-13 3:51 ` Linus Torvalds
2012-12-13 4:31 ` David Ahern
2012-12-13 4:46 ` Linus Torvalds
2012-12-13 7:27 ` Ingo Molnar
2012-12-13 7:30 ` Ingo Molnar
2012-12-13 14:30 ` David Ahern
2012-12-13 14:38 ` David Ahern
2012-12-13 16:03 ` Linus Torvalds
2012-12-13 16:24 ` David Ahern
2012-12-13 16:33 ` Linus Torvalds
2012-12-13 16:59 ` Ingo Molnar [this message]
2012-12-13 17:10 ` Linus Torvalds
2012-12-13 17:31 ` Ingo Molnar
2012-12-17 4:43 ` David Ahern
2012-12-22 19:22 ` David Ahern
2012-12-23 0:00 ` Linus Torvalds
2012-12-13 17:02 ` Linus Torvalds
2012-12-13 17:30 ` David Ahern
2012-12-13 17:36 ` Ingo Molnar
2012-12-13 19:12 ` David Ahern
2012-12-13 7:48 ` [PATCH] Revert "perf: Require exclude_guest to use PEBS - kernel side enforcement" Ingo Molnar
[not found] ` <20121217102000.GE11016@redhat.com>
2012-12-22 19:30 ` [GIT PULL] perf changes for v3.8 David Ahern
2012-12-23 9:23 ` Gleb Natapov
2012-12-23 23:17 ` David Ahern
2012-12-24 10:36 ` Gleb Natapov
2012-12-13 17:04 ` [PATCH] x86: fix perf build with uclibc toolchains Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213165904.GA18574@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.