All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: NeilBrown <neilb@suse.de>
Cc: Jon Hunter <jon-hunter@ti.com>,
	Thierry Reding <thierry.reding@avionic-design.de>,
	Grant Erickson <marathon96@gmail.com>,
	linux-omap@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] OMAP: add pwm driver using dmtimers.
Date: Thu, 13 Dec 2012 09:41:11 -0800	[thread overview]
Message-ID: <20121213174110.GE4989@atomide.com> (raw)
In-Reply-To: <20121213140635.4eda5858@notabene.brown>

* NeilBrown <neilb@suse.de> [121212 19:09]:
> On Wed, 12 Dec 2012 10:08:28 -0600 Jon Hunter <jon-hunter@ti.com> wrote:
> > On 12/12/2012 02:24 AM, NeilBrown wrote:
> > > +
> > > +	/* Request the OMAP dual-mode timer that will be bound to and
> > > +	 * associated with this generic PWM.
> > > +	 */
> > > +
> > > +	omap->dm_timer = omap_dm_timer_request_specific(timer);
> > 
> > I would recommend that you use omap_dm_timer_request_by_cap() (new for
> > v3.8 so you should be able to use once v3.8-rc1 is out) here to request
> > a timer that supports the PWM output. The above function will not be
> > supported when booting with device-tree.
> 
> I wasn't planning on rushing into working on 3.8-rcX so I'd rather not do
> this now.
> Would you object to the patch being submitted with the current call, then an
> update when I do move on to 3.8?
> 
> However.... I may be misunderstanding something, but I want a timer to drive
> a particular output pin - GPIO-57.  And I thought that it could only be
> driver by GPT11.  So I need to explicitly request number 11 don't I?

Yes I believe it needs to tied to a specific GPT instance to have access
to the pin. We should not export omap_dm_timer_request_specific(), that
information should become from platform_data and device tree.

Regards,

Tony

      parent reply	other threads:[~2012-12-13 17:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-12  8:24 [PATCH] OMAP: add pwm driver using dmtimers NeilBrown
2012-12-12 11:31 ` Thierry Reding
2012-12-12 16:20   ` Jon Hunter
2012-12-12 16:20     ` Jon Hunter
2012-12-13  2:45     ` NeilBrown
2012-12-13  2:45       ` NeilBrown
2012-12-13  2:38   ` NeilBrown
2012-12-13  7:34     ` Thierry Reding
2012-12-12 16:08 ` Jon Hunter
2012-12-12 16:08   ` Jon Hunter
2012-12-13  3:06   ` NeilBrown
2012-12-13  3:06     ` NeilBrown
2012-12-13  4:33     ` NeilBrown
2012-12-13  4:33       ` NeilBrown
2012-12-13 17:42       ` Jon Hunter
2012-12-13 17:42         ` Jon Hunter
2012-12-15  0:16         ` NeilBrown
2012-12-15  0:16           ` NeilBrown
2012-12-13  7:11     ` Thierry Reding
2012-12-13 17:07     ` Jon Hunter
2012-12-13 17:07       ` Jon Hunter
2012-12-13 17:34       ` Tony Lindgren
2013-01-06 21:12       ` NeilBrown
2013-01-06 21:12         ` NeilBrown
2013-01-07 22:24         ` Jon Hunter
2013-01-07 22:24           ` Jon Hunter
2012-12-13 17:41     ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121213174110.GE4989@atomide.com \
    --to=tony@atomide.com \
    --cc=jon-hunter@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=marathon96@gmail.com \
    --cc=neilb@suse.de \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.