From: Richard Cochran <richardcochran@gmail.com>
To: Paul Chavent <Paul.Chavent@onera.fr>
Cc: davem@davemloft.net, edumazet@google.com,
daniel.borkmann@tik.ee.ethz.ch, xemul@parallels.com,
ebiederm@xmission.com, netdev@vger.kernel.org
Subject: Re: [RFC] net : add tx timestamp to packet mmap.
Date: Thu, 13 Dec 2012 19:17:33 +0100 [thread overview]
Message-ID: <20121213181733.GA2312@netboy.at.omicron.at> (raw)
In-Reply-To: <50C9FEC4.5050804@onera.fr>
On Thu, Dec 13, 2012 at 05:13:56PM +0100, Paul Chavent wrote:
> >
> >In order for time stamps to appear, somebody has to call
> >skb_tx_timestamp() ...
> Yes. "Somebody" means "the hardware driver" after completing xmit.
> That's true ?
Yes, the MAC driver must call this helper function, but not many
drivers do this yet. You didn't say which MAC driver you are using and
whether it supports Tx SO_TIMESTAMPING or not.
> Yes, it only sets some flags. I thought that those flags was
> required by the skb_tx_timestamp() in order to make the appropriate
> timestamping (hardware, software, etc).
>
> So in order to have tx timestamp that work, both calls are needed ?
Yes.
> Why sock_tx_timestamp is called in packet_fill_skb and
> packet_sendmsg_spkt and not in tpacket_fill_skb ?
> Why i can retrieve timestamps when i add this call ?
Sorry, I don't know much about packet mmap. Last time I tried it, some
years ago, it wasn't really working.
Richard
next prev parent reply other threads:[~2012-12-13 18:17 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 15:29 [RFC] net : add tx timestamp to packet mmap Paul Chavent
2012-12-12 19:23 ` David Miller
2012-12-13 7:13 ` Paul Chavent
2012-12-13 13:29 ` Richard Cochran
2012-12-13 16:13 ` Paul Chavent
2012-12-13 18:17 ` Richard Cochran [this message]
2012-12-14 7:57 ` Paul Chavent
2013-04-09 10:42 ` Paul Chavent
2013-04-09 13:15 ` Richard Cochran
2013-04-13 18:33 ` Willem de Bruijn
2013-04-13 18:56 ` [PATCH] net-packet: tx timestamping on tpacket ring Willem de Bruijn
2013-04-13 22:18 ` Daniel Borkmann
2013-04-13 22:47 ` David Miller
2013-04-14 0:04 ` Willem de Bruijn
2013-04-14 0:16 ` Willem de Bruijn
2013-04-14 0:49 ` Willem de Bruijn
2013-04-14 5:16 ` Daniel Borkmann
2013-04-14 0:00 ` Willem de Bruijn
2013-04-14 10:52 ` Daniel Borkmann
2013-04-14 13:07 ` Richard Cochran
2013-04-15 7:37 ` Paul Chavent
2013-04-15 16:56 ` Richard Cochran
2013-04-15 16:59 ` Willem de Bruijn
2013-04-17 10:22 ` Richard Cochran
2013-04-19 21:51 ` [PATCH net-next v2] packet: " Willem de Bruijn
2013-04-20 12:33 ` Daniel Borkmann
2013-04-21 2:30 ` Willem de Bruijn
2013-04-21 10:10 ` Daniel Borkmann
2013-04-21 16:42 ` Willem de Bruijn
2013-04-21 18:14 ` Daniel Borkmann
2013-04-22 8:19 ` Paul Chavent
2013-04-22 10:25 ` Daniel Borkmann
2013-04-22 14:23 ` Willem de Bruijn
2013-04-20 16:43 ` Richard Cochran
2013-04-21 2:34 ` Willem de Bruijn
2013-04-15 15:41 ` [PATCH] net-packet: " Paul Chavent
2013-04-15 9:45 ` David Laight
2013-04-15 17:08 ` Willem de Bruijn
2013-04-15 17:31 ` David Miller
2013-04-15 7:31 ` Paul Chavent
2013-04-15 16:37 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213181733.GA2312@netboy.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=Paul.Chavent@onera.fr \
--cc=daniel.borkmann@tik.ee.ethz.ch \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.