From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Nadav Amit <nadav.amit@gmail.com>
Subject: Re: [PATCH kvm-unit-tests] emulator: test 64-bit mov with immediate operand
Date: Thu, 13 Dec 2012 19:47:49 -0200 [thread overview]
Message-ID: <20121213214748.GA8574@amt.cnet> (raw)
In-Reply-To: <1355400716-21359-1-git-send-email-pbonzini@redhat.com>
On Thu, Dec 13, 2012 at 01:11:55PM +0100, Paolo Bonzini wrote:
> MOV immediate instruction (opcodes 0xB8-0xBF) may take 64-bit operand.
> Some hypervisor implementations assumed the operand is 32-bit. This
> should never happen because the instruction has no memory operand, but
> (like the existing test_mmx_movq_mf) the testcase tricks the emulator
> into executing one by mismatching the page tables and the corresponding
> TLB entry.
>
> Cc: Nadav Amit <nadav.amit@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> x86/emulator.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
Wicked, missed that. If you're unlucky, though, TLB entry can
be gone by then (unlikely, though).
Applied, thanks.
prev parent reply other threads:[~2012-12-13 21:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 12:11 [PATCH kvm-unit-tests] emulator: test 64-bit mov with immediate operand Paolo Bonzini
2012-12-13 12:24 ` Gleb Natapov
2012-12-13 20:45 ` Marcelo Tosatti
2012-12-13 21:26 ` Gleb Natapov
2012-12-13 21:47 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213214748.GA8574@amt.cnet \
--to=mtosatti@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.