All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: fangxiaozhi 00110321 <fangxiaozhi@huawei.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<zihan@huawei.com>, <Lin.Lei@huawei.com>, <greg@kroah.com>,
	<neil.yi@huawei.com>, <wangyuhua@huawei.com>,
	<huqiao36@huawei.com>
Subject: Re: [PATCH 1/1]linux-usb: optimize to match rules in USB storage for Huawei dongles.
Date: Fri, 14 Dec 2012 11:40:20 +0200	[thread overview]
Message-ID: <20121214094020.GA15370@arwen.pp.htv.fi> (raw)
In-Reply-To: <fe6cdb1d63dd.63ddfe6cdb1d@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

On Fri, Dec 14, 2012 at 10:25:25AM +0800, fangxiaozhi 00110321 wrote:
> From: fangxiaozhi <huananhu@huawei.com>
> 
> 1. Add a new macro define for USB storage match rule.
> 2. Optimize the match rules with new macro for Huawei USB storage devices, 
>    to avoid to load USB storage driver for the modem interface 
>    with Huawei devices.
> 3. Add to support new switch command for new Huawei USB dongles.

still doing too much in a single patch. Should be broken down. Most of
my comments weren't taken into account. Why bother sending a new
version ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-12-14  9:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14  2:25 [PATCH 1/1]linux-usb: optimize to match rules in USB storage for Huawei dongles fangxiaozhi 00110321
2012-12-14  9:40 ` Felipe Balbi [this message]
2012-12-14 15:36 ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121214094020.GA15370@arwen.pp.htv.fi \
    --to=balbi@ti.com \
    --cc=Lin.Lei@huawei.com \
    --cc=fangxiaozhi@huawei.com \
    --cc=greg@kroah.com \
    --cc=huqiao36@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.yi@huawei.com \
    --cc=wangyuhua@huawei.com \
    --cc=zihan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.