From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 6/6] drm/i915: Remove stale comment about intel_dp_detect() Date: Fri, 14 Dec 2012 11:20:27 +0100 Message-ID: <20121214102027.GG5737@phenom.ffwll.local> References: <1355414944-1494-1-git-send-email-damien.lespiau@gmail.com> <1355414944-1494-6-git-send-email-damien.lespiau@gmail.com> <87fw392cgj.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by gabe.freedesktop.org (Postfix) with ESMTP id E3C0EE68C5 for ; Fri, 14 Dec 2012 02:18:54 -0800 (PST) Received: by mail-wg0-f45.google.com with SMTP id dq12so1269788wgb.12 for ; Fri, 14 Dec 2012 02:18:54 -0800 (PST) Content-Disposition: inline In-Reply-To: <87fw392cgj.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Dec 14, 2012 at 11:46:20AM +0200, Jani Nikula wrote: > On Thu, 13 Dec 2012, Damien Lespiau wrote: > > From: Damien Lespiau > > > > The function doesn't use any of the registers mentioned, nor does it > > return true or false. Hard to do worse. Remove it, the function is > > absolutely descriptive enough to not need any comment. > > Reviewed-by: Jani Nikula Entire series queued for -next, thanks for patches&review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch