Re: [Qemu-devel] [PATCH 2/3] qtest: extend qtest_qmp() to fill in the reply

[Jason Baron <jbaron@redhat.com>]

On Fri, Dec 14, 2012 at 01:07:24AM +0100, Andreas Färber wrote:
> Am 13.12.2012 23:02, schrieb Jason Baron:
> > diff --git a/tests/Makefile b/tests/Makefile
> > index b60f0fb..30a101d 100644
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -74,10 +74,10 @@ tests/test-qmp-input-strict$(EXESUF): tests/test-qmp-input-strict.o $(test-qapi-
> >  tests/test-qmp-commands$(EXESUF): tests/test-qmp-commands.o tests/test-qmp-marshal.o $(test-qapi-obj-y)
> >  tests/test-visitor-serialization$(EXESUF): tests/test-visitor-serialization.o $(test-qapi-obj-y)
> >  
> > -tests/rtc-test$(EXESUF): tests/rtc-test.o $(trace-obj-y)
> > +tests/rtc-test$(EXESUF): tests/rtc-test.o $(trace-obj-y) qstring.o
> >  tests/m48t59-test$(EXESUF): tests/m48t59-test.o $(trace-obj-y)
> > -tests/fdc-test$(EXESUF): tests/fdc-test.o tests/libqtest.o $(trace-obj-y)
> > -tests/hd-geo-test$(EXESUF): tests/hd-geo-test.o tests/libqtest.o $(trace-obj-y)
> > +tests/fdc-test$(EXESUF): tests/fdc-test.o tests/libqtest.o $(trace-obj-y) qstring.o
> > +tests/hd-geo-test$(EXESUF): tests/hd-geo-test.o tests/libqtest.o $(trace-obj-y) qstring.o
> 
> Adding a dependency to every qtest is calling for a $(qtest-obj-y) to
> administer that list in a central location. I am expecting the number of
> tests to grow significantly over time.
> 
> Andreas
> 

ok, seems as though we can add $(test-qapi-obj-y) $(qom-obj-y), etc. to the
qtest-obj-y target, to simplify things a bit. I'll re-post that as a
separate patch.

Thanks,

-Jason