All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, Thomas Weber <thomas@tomweber.eu>,
	stable@vger.kernel.org
Subject: Re: [PATCHv2] OMAP: board-files: fix i2c_bus for tfp410
Date: Fri, 14 Dec 2012 09:23:52 -0800	[thread overview]
Message-ID: <20121214172350.GS4989@atomide.com> (raw)
In-Reply-To: <50B87CD2.8010107@ti.com>

* Tomi Valkeinen <tomi.valkeinen@ti.com> [121130 01:33]:
> Hi Tony,
> 
> On 2012-11-22 10:39, Tomi Valkeinen wrote:
> > The i2c handling in tfp410 driver, which handles converting parallel RGB
> > to DVI, was changed in 958f2717b84e88bf833d996997fda8f73276f2af
> > (OMAPDSS: TFP410: pdata rewrite). The patch changed what value the
> > driver considers as invalid/undefined.  Before the patch, 0 was the
> > invalid value, but as 0 is a valid bus number, the patch changed this to
> > -1.
> > 
> > However, the fact was missed that many board files do not define the bus
> > number at all, thus it's left to 0. This causes the driver to fail to
> > get the i2c bus, exiting from the driver's probe with an error, meaning
> > that the DVI output does not work for those boards.
> > 
> > This patch fixes the issue by changing the i2c_bus number field in the
> > driver's platform data from u16 to int, and setting the bus number to -1
> > in the board files for the boards that did not define the bus. The
> > exception is devkit8000, for which the bus is set to 1, which is the
> > correct bus for that board.
> > 
> > The bug exists in v3.5+ kernels.
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > Reported-by: Thomas Weber <thomas@tomweber.eu>
> > Cc: Thomas Weber <thomas@tomweber.eu>
> > Cc: <stable@vger.kernel.org> # v3.5+
> > ---
> >  arch/arm/mach-omap2/board-3430sdp.c      |    1 +
> >  arch/arm/mach-omap2/board-am3517evm.c    |    1 +
> >  arch/arm/mach-omap2/board-cm-t35.c       |    1 +
> >  arch/arm/mach-omap2/board-devkit8000.c   |    1 +
> >  arch/arm/mach-omap2/board-omap3evm.c     |    1 +
> >  arch/arm/mach-omap2/board-omap3stalker.c |    1 +
> >  include/video/omap-panel-tfp410.h        |    2 +-
> >  7 files changed, 7 insertions(+), 1 deletion(-)
> 
> Did this make it into your v3.8 branch?

Applying now into omap-for-v3.8/fixes-for-merge-window.

Thanks,

Tony

      reply	other threads:[~2012-12-14 17:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16 12:22 [PATCH] OMAP: board-files: fix i2c_bus for tfp410 Tomi Valkeinen
2012-11-16 13:51 ` Felipe Balbi
2012-11-16 13:51   ` Felipe Balbi
     [not found]   ` <20121116135155.GE18527-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-16 14:27     ` Tomi Valkeinen
2012-11-16 14:27       ` Tomi Valkeinen
2012-11-16 15:19       ` Felipe Balbi
2012-11-16 15:19         ` Felipe Balbi
2012-11-16 15:39         ` Tomi Valkeinen
2012-11-16 15:39           ` Tomi Valkeinen
     [not found]           ` <50A65E40.9040208-l0cyMroinI0@public.gmane.org>
2012-11-16 18:21             ` tfp410 and i2c_bus_num (was: Re: [PATCH] OMAP: board-files: fix i2c_bus for tfp410) Felipe Balbi
2012-11-16 18:21               ` Felipe Balbi
     [not found]               ` <20121116182146.GC20496-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-17  5:41                 ` tfp410 and i2c_bus_num Tomi Valkeinen
2012-11-17  5:41                   ` Tomi Valkeinen
     [not found]                   ` <50A72390.3050509-l0cyMroinI0@public.gmane.org>
2012-11-18 11:34                     ` Felipe Balbi
2012-11-18 11:34                       ` Felipe Balbi
     [not found]                       ` <20121118113437.GB30462-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-19  6:38                         ` Tomi Valkeinen
2012-11-19  6:38                           ` Tomi Valkeinen
     [not found]                           ` <50A9D3DD.6040807-l0cyMroinI0@public.gmane.org>
2012-11-19  9:27                             ` Felipe Balbi
2012-11-19  9:27                               ` Felipe Balbi
     [not found]                               ` <20121119092744.GB4211-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-19 11:09                                 ` Tomi Valkeinen
2012-11-19 11:09                                   ` Tomi Valkeinen
     [not found]                                   ` <50AA1376.6060801-l0cyMroinI0@public.gmane.org>
2012-11-19 12:16                                     ` Felipe Balbi
2012-11-19 12:16                                       ` Felipe Balbi
     [not found]                                       ` <20121119121630.GC15540-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-21 17:57                                         ` Tony Lindgren
2012-11-21 17:57                                           ` Tony Lindgren
2012-11-22  8:28                                           ` Tomi Valkeinen
2012-11-22  8:28                                             ` Tomi Valkeinen
2012-11-22  8:39 ` [PATCHv2] OMAP: board-files: fix i2c_bus for tfp410 Tomi Valkeinen
2012-11-27 10:02   ` Thomas Weber
2012-11-30  9:30   ` Tomi Valkeinen
2012-12-14 17:23     ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121214172350.GS4989@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=thomas@tomweber.eu \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.