From: Andrew Lunn <andrew@lunn.ch>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Dave Jones <davej@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jamie Lentin <jm@lentin.co.uk>, Simon Baatz <gmbnomis@gmail.com>,
Jason Cooper <jason@lakedaemon.net>
Subject: Re: power: Add simple poweroff-gpio driver
Date: Fri, 14 Dec 2012 20:53:40 +0100 [thread overview]
Message-ID: <20121214195340.GC7717@lunn.ch> (raw)
In-Reply-To: <50CB5014.6030004@wwwdotorg.org>
> > I think it needs to be on the menuconfig, rather than the child options.
> > I don't have OF_GPIO, but I still got asked for the former.
>
> The menuconfig enables a class of drivers (at least theoretically in the
> future, when more such drivers turn up), and there's no reason to
> believe that all of those drivers will depend on OF. So in my opinion,
> making POWER_RESET_GPIO depend on OF makes sense, but making POWER_RESET
> depend on it doesn't.
I have another driver coming soon which will not depend on OF_GPIO. It
does however depend on OF. Its for a class of boards which have a
microcontroller controlling the main power supply, and sending an
character over a UART port is used to turn the board power off.
There might also be some legacy drivers which could be moved here
which don't depend on OF at all.
So i would prefer to keep POWER_RESET generic.
Andrew
next prev parent reply other threads:[~2012-12-14 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121213202157.8106C66071E@gitolite.kernel.org>
2012-12-13 20:51 ` power: Add simple poweroff-gpio driver Dave Jones
2012-12-14 8:21 ` Andrew Lunn
2012-12-14 10:40 ` Jamie Lentin
2012-12-14 15:08 ` Dave Jones
2012-12-14 16:13 ` Stephen Warren
2012-12-14 19:53 ` Andrew Lunn [this message]
2012-12-14 20:05 ` Dave Jones
2012-12-14 21:53 ` Andrew Lunn
2012-12-14 21:59 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214195340.GC7717@lunn.ch \
--to=andrew@lunn.ch \
--cc=davej@redhat.com \
--cc=gmbnomis@gmail.com \
--cc=jason@lakedaemon.net \
--cc=jm@lentin.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.