From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 1/2] thermal: Add support for thermal sensor for Orion SoC Date: Fri, 14 Dec 2012 23:11:59 +0100 Message-ID: <20121214221159.GE7717@lunn.ch> References: <1355482986-885-1-git-send-email-andrew@lunn.ch> <1355482986-885-2-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from londo.lunn.ch ([80.238.139.98]:46737 "EHLO londo.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755876Ab2LNWMQ (ORCPT ); Fri, 14 Dec 2012 17:12:16 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Nobuhiro Iwamatsu Cc: Andrew Lunn , linux ARM , linux-pm@vger.kernel.org, Jason Cooper , Sebastian Hesselbarth , Thomas Petazzoni , jgunthorpe@obsidianresearch.com On Sat, Dec 15, 2012 at 06:54:17AM +0900, Nobuhiro Iwamatsu wrote: > Hi, > > Thanks you for your work. > Sorry, I dont hava a time at this week about this. Its not a problem. We have plenty of time before the next merge window. I was just interested in seeing it work on my QNAP device, so did some of the cleanup work. > On Fri, Dec 14, 2012 at 8:03 PM, Andrew Lunn wrote: > > From: Nobuhiro Iwamatsu > > > > Some Orion SoC has thermal sensor. > > This patch adds support for 88F6282 and 88F6283. > > > > Signed-off-by: Nobuhiro Iwamatsu > > Signed-off-by: Andrew Lunn > > --- > > .../devicetree/bindings/thermal/orion-thermal.txt | 16 +++ > > drivers/thermal/Kconfig | 7 ++ > > drivers/thermal/Makefile | 1 + > > drivers/thermal/orion_thermal.c | 133 ++++++++++++++++++++ > > 4 files changed, 157 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/orion-thermal.txt > > create mode 100644 drivers/thermal/orion_thermal.c > > > > diff --git a/Documentation/devicetree/bindings/thermal/orion-thermal.txt b/Documentation/devicetree/bindings/thermal/orion-thermal.txt > > new file mode 100644 > > index 0000000..5ce925d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/orion-thermal.txt > > @@ -0,0 +1,16 @@ > > +* Orion Thermal > > + > > +This initial version is for Kirkwood 88F8262 & 88F6283 SoCs, however > > +it is expected the driver will sometime in the future be expanded to > > +also support Dove, using a different compatibility string. > > + > > +Required properties: > > +- compatible : "marvell,kirkwood-thermal" > > +- reg : Address range of the thermal registers > > + > > +Example: > > + > > + thermal@10078 { > > + compatible = "marvell,kirkwood"; > > compatible = "marvell,kirkwood-thermal"; ? Yep, my error. > > + reg = <0x10078 0x4>; > > + }; > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index e1cb6bd..3bba13f 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -55,3 +55,10 @@ config EXYNOS_THERMAL > > help > > If you say yes here you get support for TMU (Thermal Managment > > Unit) on SAMSUNG EXYNOS series of SoC. > > + > > +config ORION_THERMAL > > + tristate "Temperature sensor on Marvel Orion SoCs" > > Marvel -> Marvell Missed that one, thanks. Thanks for the Tested-by. I will add it to the next version. I started work on Dove support, so i will probably repost when i have that ready for testing. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Fri, 14 Dec 2012 23:11:59 +0100 Subject: [PATCH 1/2] thermal: Add support for thermal sensor for Orion SoC In-Reply-To: References: <1355482986-885-1-git-send-email-andrew@lunn.ch> <1355482986-885-2-git-send-email-andrew@lunn.ch> Message-ID: <20121214221159.GE7717@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Dec 15, 2012 at 06:54:17AM +0900, Nobuhiro Iwamatsu wrote: > Hi, > > Thanks you for your work. > Sorry, I dont hava a time at this week about this. Its not a problem. We have plenty of time before the next merge window. I was just interested in seeing it work on my QNAP device, so did some of the cleanup work. > On Fri, Dec 14, 2012 at 8:03 PM, Andrew Lunn wrote: > > From: Nobuhiro Iwamatsu > > > > Some Orion SoC has thermal sensor. > > This patch adds support for 88F6282 and 88F6283. > > > > Signed-off-by: Nobuhiro Iwamatsu > > Signed-off-by: Andrew Lunn > > --- > > .../devicetree/bindings/thermal/orion-thermal.txt | 16 +++ > > drivers/thermal/Kconfig | 7 ++ > > drivers/thermal/Makefile | 1 + > > drivers/thermal/orion_thermal.c | 133 ++++++++++++++++++++ > > 4 files changed, 157 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/orion-thermal.txt > > create mode 100644 drivers/thermal/orion_thermal.c > > > > diff --git a/Documentation/devicetree/bindings/thermal/orion-thermal.txt b/Documentation/devicetree/bindings/thermal/orion-thermal.txt > > new file mode 100644 > > index 0000000..5ce925d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/orion-thermal.txt > > @@ -0,0 +1,16 @@ > > +* Orion Thermal > > + > > +This initial version is for Kirkwood 88F8262 & 88F6283 SoCs, however > > +it is expected the driver will sometime in the future be expanded to > > +also support Dove, using a different compatibility string. > > + > > +Required properties: > > +- compatible : "marvell,kirkwood-thermal" > > +- reg : Address range of the thermal registers > > + > > +Example: > > + > > + thermal at 10078 { > > + compatible = "marvell,kirkwood"; > > compatible = "marvell,kirkwood-thermal"; ? Yep, my error. > > + reg = <0x10078 0x4>; > > + }; > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index e1cb6bd..3bba13f 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -55,3 +55,10 @@ config EXYNOS_THERMAL > > help > > If you say yes here you get support for TMU (Thermal Managment > > Unit) on SAMSUNG EXYNOS series of SoC. > > + > > +config ORION_THERMAL > > + tristate "Temperature sensor on Marvel Orion SoCs" > > Marvel -> Marvell Missed that one, thanks. Thanks for the Tested-by. I will add it to the next version. I started work on Dove support, so i will probably repost when i have that ready for testing. Andrew