Re: [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion

[Marcelo Tosatti <mtosatti@redhat.com>]

On Sat, Dec 15, 2012 at 01:45:38PM +0000, Julien Grall wrote:
> On Fri, Dec 14, 2012 at 11:39 PM, Marcelo Tosatti <mtosatti@redhat.com> wrote:
> >
> >
> > The high byte of the ioport address is necessary to compute
> > the register address, see "82371AB PCI ISA IDE Xcelerator (PIIX4)"
> > document, eg:
> >
> > 4.2.1.1. DCOM—DMA Command Register (IO)
> > I/O Address: Channels 0–3—08h; Channels 4–7—0D0h
> >
> 
> I sent a patch on the mailing to resolve the problem yesterday
> (http://www.mail-archive.com/qemu-devel@nongnu.org/msg145242.html).
> Did it resolve your WinXp-32 installation? I just need to rework the comment.

Yes it does.

> >
> > Also the size of the region is wrong.
> 
> I don't think the size of the region is wrong. For the second DMA
> controller, the ioports are 0xD0 - 0xDE for the control registers.
> So the size is 16 not 8. It's the same for the channel registers.
> 
> Thanks,

Correct, my patch is broken.

Thanks