From: Adam Spiers <git@adamspiers.org>
To: git mailing list <git@vger.kernel.org>
Subject: $PATH pollution and t9902-completion.sh
Date: Mon, 17 Dec 2012 01:05:38 +0000 [thread overview]
Message-ID: <20121217010538.GC3673@gmail.com> (raw)
t/t9902-completion.sh is currently failing for me because I happen to
have a custom shell-script called git-check-email in ~/bin, which is
on my $PATH. This is different to a similar-looking case reported
recently, which was due to an unclean working tree:
http://thread.gmane.org/gmane.comp.version-control.git/208085
It's not unthinkable that in the future other tests could break for
similar reasons. Therefore it would be good to sanitize $PATH in the
test framework so that it cannot destabilize tests, although I am
struggling to think of a good way of doing this. Naively stripping
directories under $HOME would not protect against git "plugins" such
as the above being installed into places like /usr/bin. Thoughts?
next reply other threads:[~2012-12-17 1:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 1:05 Adam Spiers [this message]
2012-12-20 14:55 ` $PATH pollution and t9902-completion.sh Jeff King
2012-12-20 15:13 ` Adam Spiers
2012-12-20 17:25 ` Torsten Bögershausen
2012-12-20 18:36 ` Junio C Hamano
2012-12-20 19:55 ` Junio C Hamano
2012-12-20 20:01 ` Jeff King
2012-12-20 20:53 ` Torsten Bögershausen
2012-12-20 21:02 ` Junio C Hamano
2012-12-20 21:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217010538.GC3673@gmail.com \
--to=git@adamspiers.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.