From: Oleg Nesterov <oleg@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
Pavel Emelyanov <xemul@parallels.com>,
Neil Horman <nhorman@tuxdriver.com>,
Daniel Berrange <berrange@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Serge Hallyn <serge.hallyn@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: + core_pattern-set-core-helpers-root-and-namespace-to-crashing-process .patch added to -mm tree
Date: Mon, 17 Dec 2012 13:34:28 +0100 [thread overview]
Message-ID: <20121217123428.GA1957@redhat.com> (raw)
@@ -455,6 +468,14 @@ static int umh_pipe_setup(struct subproc
/* and disallow core files too */
current->signal->rlim[RLIMIT_CORE] = (struct rlimit){1, 1};
+
+ if (cp->switch_ns) {
+ get_fs_root(cp->cprocess->fs, &root);
+ set_fs_root(current->fs, &root);
+ switch_task_namespaces(current, cp->cprocess->nsproxy);
How? You can't simply change ->nsproxy this way.
If nothing else this breaks sys_getpid(), no?
And a lot more problems, afaics. For example, this thread can continue
to run after, say, this cprocess->nsproxy->pid_ns was already destroyed.
zap_pid_ns_processes() obviously won't see this thread.
Even ->nsproxy itself can go away. Just suppose that the coredumping
task is the only process in this namespace (sub-init).
Oleg.
next reply other threads:[~2012-12-17 12:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 12:34 Oleg Nesterov [this message]
2012-12-17 15:05 ` + core_pattern-set-core-helpers-root-and-namespace-to-crashing-process .patch added to -mm tree Neil Horman
2012-12-17 16:04 ` Oleg Nesterov
2012-12-17 18:39 ` Neil Horman
2012-12-18 20:06 ` Oleg Nesterov
2012-12-18 20:19 ` Neil Horman
2012-12-18 20:45 ` Eric W. Biederman
2012-12-18 21:53 ` Neil Horman
2012-12-19 4:43 ` Eric W. Biederman
2012-12-19 16:34 ` Oleg Nesterov
2012-12-19 16:22 ` Oleg Nesterov
2012-12-19 20:42 ` Neil Horman
2012-12-20 13:02 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217123428.GA1957@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=berrange@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=serge.hallyn@canonical.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.