From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Implement workaround for broken CS tlb on i830/845 Date: Mon, 17 Dec 2012 14:43:03 +0100 Message-ID: <20121217134303.GO5737@phenom.ffwll.local> References: <1355697960-8063-1-git-send-email-chris@chris-wilson.co.uk> <6c3329$7mbtk2@orsmga002.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 3DC10E5C0C for ; Mon, 17 Dec 2012 05:41:30 -0800 (PST) Received: by mail-wi0-f173.google.com with SMTP id hn17so1908056wib.12 for ; Mon, 17 Dec 2012 05:41:29 -0800 (PST) Content-Disposition: inline In-Reply-To: <6c3329$7mbtk2@orsmga002.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Dec 17, 2012 at 01:33:01PM +0000, Chris Wilson wrote: > On Sun, 16 Dec 2012 22:46:00 +0000, Chris Wilson wrote: > > @@ -1087,6 +1087,9 @@ i915_error_first_batchbuffer(struct drm_i915_private *dev_priv, > > if (!ring->get_seqno) > > return NULL; > > > > + if (HAS_BROKEN_CS_TLB(dev_priv->dev)) > > + return i915_error_object_create(dev_priv, ring->private); > > Hmm, this is complicated by userspace opting out of the CS w/a, and > imposes quite a burden upon our simple seq interface. Right, I've written this without userspace being able to opt out in mind ... for the seq -ENOMEM, I guess it's just time to bite the bullet. Loads of the error_states for the ilk fallout couldn't be dumped (but could be captured) by bug reporters already :( -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch