From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sebastian Wankerl <sisewank@cip.cs.fau.de>
Cc: linux-kernel@i4.informatik.uni-erlangen.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Sebastian Wankerl
<sisewank@faui49man10.informatik.uni-erlangen.de>,
Sebastian Ehrenfels <qi50dube@cip.cs.fau.de>
Subject: Re: [PATCH 3/3] wlan-ng/prism2mgmt.c Replace printk(...) with netdev_warn, netdev_err
Date: Mon, 17 Dec 2012 17:13:45 +0300 [thread overview]
Message-ID: <20121217141345.GS5083@mwanda> (raw)
In-Reply-To: <1355751483-7059-3-git-send-email-sisewank@cip.cs.fau.de>
On Mon, Dec 17, 2012 at 02:38:03PM +0100, Sebastian Wankerl wrote:
> @@ -261,15 +265,17 @@ int prism2mgmt_scan(wlandevice_t *wlandev, void *msgp)
> HFA384x_RID_CREATEIBSS,
> HFA384x_CREATEIBSS_JOINCREATEIBSS);
> if (result) {
> - printk(KERN_ERR "Failed to set CREATEIBSS.\n");
> + netdev_err(wlandev->netdev,
> + "Failed to set CREATEIBSS.\n");
> msg->resultcode.data =
> P80211ENUM_resultcode_implementation_failure;
> goto exit;
> }
> result = hfa384x_drvr_enable(hw, 0);
> if (result) {
> - printk(KERN_ERR "drvr_enable(0) failed. "
> - "result=%d\n", result);
> + netdev_err(wlandev->netdev,
> + "drvr_enable(0) failed. " "result=%d\n",
^^^
Delete this.
regards,
dan carpenter
next prev parent reply other threads:[~2012-12-17 14:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 13:38 [PATCH 1/3] wlan-ng/prism2mgmt.c: added parenthesis to macro Sebastian Wankerl
2012-12-17 13:38 ` [PATCH 2/3] wlan-ng/prism2mgmt.c: formated too long lines Sebastian Wankerl
2012-12-17 14:08 ` Dan Carpenter
2012-12-17 13:38 ` [PATCH 3/3] wlan-ng/prism2mgmt.c Replace printk(...) with netdev_warn, netdev_err Sebastian Wankerl
2012-12-17 14:13 ` Dan Carpenter [this message]
2012-12-17 14:00 ` [PATCH 1/3] wlan-ng/prism2mgmt.c: added parenthesis to macro Dan Carpenter
2012-12-18 21:47 ` Sebastian Ehrenfels
2013-01-17 20:58 ` Greg Kroah-Hartman
2013-01-17 23:07 ` [i4passt_all] " Sebastian Ehrenfels
2013-01-17 23:07 ` Sebastian Ehrenfels
2013-01-18 21:02 ` Greg Kroah-Hartman
2013-01-17 23:07 ` [PATCH 2/3] wlan-ng/prism2mgmt.c: formated too long lines Sebastian Ehrenfels
2013-01-18 21:00 ` Greg Kroah-Hartman
2013-01-17 23:07 ` [PATCH 3/3] wlan-ng/prism2mgmt.c Replace printk(...) with netdev_warn, netdev_err Sebastian Ehrenfels
2013-01-18 21:01 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217141345.GS5083@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@i4.informatik.uni-erlangen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=qi50dube@cip.cs.fau.de \
--cc=sisewank@cip.cs.fau.de \
--cc=sisewank@faui49man10.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.