From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fixup overlay stolen memory leak
Date: Tue, 18 Dec 2012 16:07:40 +0100
Message-ID: <20121218150733.GW5737@phenom.ffwll.local>
References: <1355840677-678-1-git-send-email-daniel.vetter@ffwll.ch>
	<84c8a8$70rcbb@orsmga001.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45])
	by gabe.freedesktop.org (Postfix) with ESMTP id 25F71E5D3B
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 18 Dec 2012 07:06:06 -0800 (PST)
Received: by mail-ee0-f45.google.com with SMTP id d49so412851eek.32
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 18 Dec 2012 07:06:06 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <84c8a8$70rcbb@orsmga001.jf.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Dec 18, 2012 at 02:48:39PM +0000, Chris Wilson wrote:
> On Tue, 18 Dec 2012 15:24:37 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > We need to clean up the overlay first, before taking down the
> > stolen memory allocator.
> > 
> > This regression has been introducec in
> > 
> > commit 8040513870399f1cb032cb8bc805df5042fedcdf
> > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > Date:   Thu Nov 15 11:32:29 2012 +0000
> > 
> >     drm/i915: Allocate overlay registers from stolen memory
> > 
> > Note: This is just a quick hack to shut up a warning in the module
> > unload code, so that I can check again whether we don't leak any
> > framebuffers.

Dropped this note, since it's no longer a hack ...

> > v2: Rework the patch a bit as suggested by Chris Wilson:
> > - move the overlay teardown up, into the modeset cleanup
> > - move the stolen mm takedown into i915_gem_cleanup_stolen
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> That organisation indeed makes more sense.
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

... and merged it. Thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch