From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jun Chen <jun.d.chen@intel.com>
Cc: grant.likely@secretlab.ca, linux-kernel@vger.kernel.org,
Bi Chao <chao.bi@intel.com>,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.
Date: Tue, 18 Dec 2012 15:26:26 +0000 [thread overview]
Message-ID: <20121218152623.GA26077@sirena.org.uk> (raw)
In-Reply-To: <1355848174.1435.25.camel@chenjun-workstation>
On Tue, Dec 18, 2012 at 11:29:34AM -0500, Jun Chen wrote:
> * @master: Controller to which device is connected
> + * device_was_children_of_master is flag which the device is registed
> + * as the children of the bus
This isn't a kerneldoc style comment (it needs the @XXX: format). The
name is also extremely long, can't we think of something more concise?
> - spi->dev.parent = &master->dev;
> + if (device_was_children_of_master == true)
> + spi->dev.parent = &master->dev;
> + else
> + spi->dev.parent = dev;
Can you provide an example of where this is useful? Your changelog
didn't make it clear and the code doesn't make it obvious either.
next prev parent reply other threads:[~2012-12-18 15:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 16:29 [PATCH] spi: Add the flag indicate to registe new device as children of master or not Jun Chen
2012-12-18 16:29 ` Jun Chen
2012-12-18 15:26 ` Mark Brown [this message]
[not found] ` <20121218152623.GA26077-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-12-19 9:44 ` Jun Chen
2012-12-19 9:44 ` Jun Chen
2012-12-19 9:04 ` Mark Brown
[not found] ` <20121219090416.GK4985-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-12-19 16:21 ` Grant Likely
2012-12-19 16:21 ` Grant Likely
2012-12-21 17:39 ` Jun Chen
2012-12-21 17:39 ` Jun Chen
2012-12-21 19:06 ` Grant Likely
2012-12-24 16:16 ` Jun Chen
2013-01-11 14:57 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218152623.GA26077@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=chao.bi@intel.com \
--cc=grant.likely@secretlab.ca \
--cc=jun.d.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.