From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56913)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1Tkz4S-00015Y-CQ
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 10:27:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1Tkz4N-0005Vc-Go
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 10:27:04 -0500
Received: from mx1.redhat.com ([209.132.183.28]:27396)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1Tkz4N-0005VV-9V
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 10:26:59 -0500
Date: Tue, 18 Dec 2012 13:28:29 -0200
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20121218152829.GF5334@otherpad.lan.raisama.net>
References: <1355760092-18755-1-git-send-email-imammedo@redhat.com>
	<1355760092-18755-8-git-send-email-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1355760092-18755-8-git-send-email-imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 07/20] target-i386: cpu_x86_register()
 consolidate freeing resources
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Don@CloudSwitch.com, qemu-devel@nongnu.org, afaerber@suse.de

On Mon, Dec 17, 2012 at 05:01:19PM +0100, Igor Mammedov wrote:
> freeing resources in one place would require setting 'error'
> to not NULL, so add some more error reporting before jumping to
> exit branch.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
[...]
> +out:
> +    g_strfreev(model_pieces);
>      if (error) {
>          fprintf(stderr, "%s\n", error_get_pretty(error));
>          error_free(error);
> -        goto error;
>      }
> -
> -    g_strfreev(model_pieces);


You are making the function return 0 on errors. Is it on purpose?


>      return 0;
> -error:
> -    g_strfreev(model_pieces);
> -    return -1;
>  }
>  
>  #if !defined(CONFIG_USER_ONLY)
> -- 
> 1.7.1
> 
> 

-- 
Eduardo