From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 18 Dec 2012 19:03:34 +0000 Subject: Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL Message-Id: <20121218190334.GK5032@mwanda> List-Id: References: <1355852048-23188-1-git-send-email-linux@prisktech.co.nz> <1355852048-23188-4-git-send-email-linux@prisktech.co.nz> <20121218183944.GH5032@mwanda> <1355856767.23479.3.camel@gitbox> In-Reply-To: <1355856767.23479.3.camel@gitbox> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tony Prisk Cc: Mike Turquette , kernel-janitors@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , linux-arm-kernel@lists.infradead.org I don't care either way, but being different from the documentation is less bad than crashing which is what your patch does. Please be more careful in the future. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: dan.carpenter@oracle.com (Dan Carpenter) Date: Tue, 18 Dec 2012 22:03:34 +0300 Subject: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL In-Reply-To: <1355856767.23479.3.camel@gitbox> References: <1355852048-23188-1-git-send-email-linux@prisktech.co.nz> <1355852048-23188-4-git-send-email-linux@prisktech.co.nz> <20121218183944.GH5032@mwanda> <1355856767.23479.3.camel@gitbox> Message-ID: <20121218190334.GK5032@mwanda> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org I don't care either way, but being different from the documentation is less bad than crashing which is what your patch does. Please be more careful in the future. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL Date: Tue, 18 Dec 2012 22:03:34 +0300 Message-ID: <20121218190334.GK5032@mwanda> References: <1355852048-23188-1-git-send-email-linux@prisktech.co.nz> <1355852048-23188-4-git-send-email-linux@prisktech.co.nz> <20121218183944.GH5032@mwanda> <1355856767.23479.3.camel@gitbox> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by gabe.freedesktop.org (Postfix) with ESMTP id D77BCE5C6C for ; Tue, 18 Dec 2012 11:03:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <1355856767.23479.3.camel@gitbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Tony Prisk Cc: Mike Turquette , kernel-janitors@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org I don't care either way, but being different from the documentation is less bad than crashing which is what your patch does. Please be more careful in the future. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755564Ab2LRTD7 (ORCPT ); Tue, 18 Dec 2012 14:03:59 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:34551 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357Ab2LRTD5 (ORCPT ); Tue, 18 Dec 2012 14:03:57 -0500 Date: Tue, 18 Dec 2012 22:03:34 +0300 From: Dan Carpenter To: Tony Prisk Cc: kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , dri-devel@lists.freedesktop.org, Mike Turquette Subject: Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL Message-ID: <20121218190334.GK5032@mwanda> References: <1355852048-23188-1-git-send-email-linux@prisktech.co.nz> <1355852048-23188-4-git-send-email-linux@prisktech.co.nz> <20121218183944.GH5032@mwanda> <1355856767.23479.3.camel@gitbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355856767.23479.3.camel@gitbox> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I don't care either way, but being different from the documentation is less bad than crashing which is what your patch does. Please be more careful in the future. regards, dan carpenter