From: Mattia Dongili <malattia@linux.it>
To: Zhang Rui <rui.zhang@intel.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: sony-laptop: fix SNC buffer calls when SN06 returns Integers
Date: Wed, 19 Dec 2012 06:39:58 +0900 [thread overview]
Message-ID: <20121218213958.GA28648@kamineko.org> (raw)
In-Reply-To: <1355814524.19698.19.camel@rzhang1-mobl4>
On Tue, Dec 18, 2012 at 03:08:44PM +0800, Zhang Rui wrote:
> Hi, Mattia,
Hi Rui!
> I generated a similar patch as yours but I still have one concern about the fix.
thanks for taking care of that.
> memcpy(buffer, (void *)&object->integer.value, len) may break the byte order but
> sony_nc_rfkill_setup() terminates if byte 0xff is checked.
> is this true? or am I thinking wrong?
You're correct, sony_nc_rfkill_setup() stops looking at the buffer as
soon as it hits 0xff but why do you think memcpy would break the byte
order?
--
mattia
:wq!
next prev parent reply other threads:[~2012-12-18 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 7:08 sony-laptop: fix SNC buffer calls when SN06 returns Integers Zhang Rui
2012-12-18 21:39 ` Mattia Dongili [this message]
2012-12-19 1:00 ` Zhang Rui
2012-12-19 22:08 ` Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218213958.GA28648@kamineko.org \
--to=malattia@linux.it \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.