From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: The hw does not support source
 offsets into a YUV linear fb
Date: Wed, 19 Dec 2012 14:14:35 +0200
Message-ID: <20121219121435.GW29018@intel.com>
References: <1355871094-5502-1-git-send-email-chris@chris-wilson.co.uk>
	<CAKMK7uHrkdx8ujh+oo5tFhs7EOVXd_JHOdRDOSNM-4OjJJDssg@mail.gmail.com>
	<20121219115612.GT29018@intel.com>
	<453bf0$6uvsn6@azsmga001.ch.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8A1C3E5D3C
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 19 Dec 2012 04:14:39 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <453bf0$6uvsn6@azsmga001.ch.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Dec 19, 2012 at 12:03:09PM +0000, Chris Wilson wrote:
> On Wed, 19 Dec 2012 13:56:12 +0200, Ville Syrj=E4l=E4 <ville.syrjala@linu=
x.intel.com> wrote:
> > On Tue, Dec 18, 2012 at 11:57:05PM +0100, Daniel Vetter wrote:
> > > On Tue, Dec 18, 2012 at 11:51 PM, Chris Wilson <chris@chris-wilson.co=
.uk> wrote:
> > > > As we can only pass in the base address of the first plane, we can =
not
> > > > control the offset into the subsampled chroma planes. This means th=
at we
> > > > cannot support a source offset into a YUV* linear framebuffer. Howe=
ver,
> > > > for tiled framebuffers we can tell the hardware which pixels to read
> > > > from. So if we see a source offset into a linear YUV framebuffer, r=
eport
> > > > the invalid value back to userspace.
> > > >
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > =

> > I can't see the original mail with the patch, where did it go?
> > =

> > > Aren't all the yuv formats we support packet planar?
> > =

> > No idea what packet planar means. All we currently support are packed
> > formats. The problem is that our code doesn't handle fb->offsets[].
> > =

> > If you're talking about src_x,src_y then those do work, at least on my
> > atomic branch. I don't remember changing the src_x/src_y related code
> > that much (apart from adding proper clipping), so I'm fairly sure they
> > should work in the upstream code as well.
> =

> They only work with a tiled source, as far as my investigation into the
> current code revealed.

Ah yeah it's the fb->bits_per_pixel problem. I though I submitted the
change to drm_format_plane_cpp() from my atomic branch, but I can't see
it in the upstream code. Either I forgot it, or it never got applied.

-- =

Ville Syrj=E4l=E4
Intel OTC