All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Bug report in pkg-autotools.mk
Date: Wed, 19 Dec 2012 13:35:07 +0100	[thread overview]
Message-ID: <20121219133507.058bf1ea@skate> (raw)
In-Reply-To: <CAExA2HxbO1X8zt_+Q=BtUhqnWCCSeNGZ3ALR_FhJmhWnpGLBHA@mail.gmail.com>

Dear Yvan Roch,

On Wed, 19 Dec 2012 12:32:43 +0100, Yvan Roch wrote:

> In the pkg-autotools.mk file, line 238 (BR2012.11) or
> Makefile.autotools.in line 250 (BR2012.02), there is the following
> command:
> 
> $$(SED) "s:\(['= ]\)/usr:\\1$(STAGING_DIR)/usr:g" $$$$i; \
> 
> This command corrects the bad path for libraries installed in the
> staging directory in the libtool .la files.
> 
> But, if Buildroot resides in a directory that contains /usr (for
> example /usr/local/src/buildroot-2012.11), $(STAGING_DIR) contains
> /usr and this command is not idempotent.
> Each time an autotools package is built, the paths in .la files are
> longer and false.

Indeed. I have a patch fixing that:

-               $$(SED) "s:\(['= ]\)/usr:\\1$(STAGING_DIR)/usr:g" $$$$i; \
+               $$(SED) "\:['= ]$(STAGING_DIR)/usr:!s:\(['= ]\)/usr:\\1$(STAGING_DIR)/usr:g" $$$$i; \

However, using a Buildroot in /usr is still broken after that, due to
libglib2 having .la files with incorrect paths (paths pointing to the
build directory). I haven't managed to fix those, so I didn't yet send
the patch to fix the more general .la files problem.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-12-19 12:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-19 11:32 [Buildroot] Bug report in pkg-autotools.mk Yvan Roch
2012-12-19 12:35 ` Thomas Petazzoni [this message]
2012-12-19 13:15   ` Yvan Roch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121219133507.058bf1ea@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.