From: Andrew Morton <akpm@linux-foundation.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'LKML'" <linux-kernel@vger.kernel.org>,
"'Richard Purdie'" <rpurdie@rpsys.net>,
"'Joe Perches'" <joe@perches.com>,
"'Devendra Naga'" <devendra.aaru@gmail.com>,
"'Ilho Lee'" <ilho215.lee@samsung.com>
Subject: Re: [PATCH v2] backlight: add lms501kf03 LCD driver
Date: Wed, 19 Dec 2012 15:07:16 -0800 [thread overview]
Message-ID: <20121219150716.d37f5e75.akpm@linux-foundation.org> (raw)
In-Reply-To: <005201cddcfc$36ac4020$a404c060$%han@samsung.com>
On Tue, 18 Dec 2012 17:46:46 +0900
Jingoo Han <jg1.han@samsung.com> wrote:
> Add the lms501kf03 LCD panel driver. The lms501kf03 LCD panel (800
> x 480) driver uses 3-wired SPI inteface.
Looks OK.
> +static unsigned int before_power;
This is unused. Can I zap it?
--- a/drivers/video/backlight/lms501kf03.c~backlight-add-lms501kf03-lcd-driver-fix
+++ a/drivers/video/backlight/lms501kf03.c
@@ -388,7 +388,6 @@ static int lms501kf03_remove(struct spi_
}
#if defined(CONFIG_PM)
-static unsigned int before_power;
static int lms501kf03_suspend(struct spi_device *spi, pm_message_t mesg)
{
@@ -396,8 +395,6 @@ static int lms501kf03_suspend(struct spi
dev_dbg(&spi->dev, "lcd->power = %d\n", lcd->power);
- before_power = lcd->power;
-
/*
* when lcd panel is suspend, lcd panel becomes off
* regardless of status.
_
prev parent reply other threads:[~2012-12-19 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 8:46 [PATCH v2] backlight: add lms501kf03 LCD driver Jingoo Han
2012-12-18 9:09 ` devendra.aaru
2012-12-19 23:07 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219150716.d37f5e75.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=devendra.aaru@gmail.com \
--cc=ilho215.lee@samsung.com \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.