From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41582)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1TlUrG-0003op-Q5
	for qemu-devel@nongnu.org; Wed, 19 Dec 2012 20:23:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1TlUrE-0003kB-2R
	for qemu-devel@nongnu.org; Wed, 19 Dec 2012 20:23:34 -0500
Received: from csmailer.cs.nctu.edu.tw ([140.113.235.130]:47183)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1TlUrD-0003jR-Hm
	for qemu-devel@nongnu.org; Wed, 19 Dec 2012 20:23:31 -0500
Date: Thu, 20 Dec 2012 09:23:18 +0800
From: =?utf-8?B?6Zmz6Z+L5Lu7IChXZWktUmVuIENoZW4p?= <chenwj@iis.sinica.edu.tw>
Message-ID: <20121220012318.GA10284@cs.nctu.edu.tw>
References: <20121210161555.GA44699@cs.nctu.edu.tw>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20121210161555.GA44699@cs.nctu.edu.tw>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] target-mips: Use EXCP_SC rather than a
 magic number
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: "Johnson, Eric" <ericj@mips.com>, Aurelien Jarno <aurelien@aurel32.net>

  ping? :-)

On Tue, Dec 11, 2012 at 12:15:55AM +0800, =E9=99=B3=E9=9F=8B=E4=BB=BB (We=
i-Ren Chen) wrote:
>   From the discussion on the ML [1], the exception limit defined by
> magic number 0x100 is actually EXCP_SC defined in cpu.h. Replace the
> magic number with EXCP_SC. Remove "#if 1 .. #endif" as well.
>=20
> [1] http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg03080.html
>=20
> Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
> ---
>  target-mips/op_helper.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index f45d494..98a445c 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -39,10 +39,10 @@ static inline void QEMU_NORETURN do_raise_exception=
_err(CPUMIPSState *env,
>                                                          uintptr_t pc)
>  {
>      TranslationBlock *tb;
> -#if 1
> -    if (exception < 0x100)
> +    if (exception < EXCP_SC) {
>          qemu_log("%s: %d %d\n", __func__, exception, error_code);
> -#endif
> +    }
> +
>      env->exception_index =3D exception;
>      env->error_code =3D error_code;
> =20
> --=20
> 1.7.3.4

--=20
Wei-Ren Chen (=E9=99=B3=E9=9F=8B=E4=BB=BB)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj