From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlVej-0005eT-MV for qemu-devel@nongnu.org; Wed, 19 Dec 2012 21:14:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlVed-0007v4-9P for qemu-devel@nongnu.org; Wed, 19 Dec 2012 21:14:41 -0500 Received: from csmailer.cs.nctu.edu.tw ([140.113.235.130]:14338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlVeb-0007ub-CF for qemu-devel@nongnu.org; Wed, 19 Dec 2012 21:14:35 -0500 Date: Thu, 20 Dec 2012 10:14:20 +0800 From: =?utf-8?B?6Zmz6Z+L5Lu7IChXZWktUmVuIENoZW4p?= Message-ID: <20121220021420.GA11565@cs.nctu.edu.tw> References: <20121210161555.GA44699@cs.nctu.edu.tw> <20121220012318.GA10284@cs.nctu.edu.tw> <1355968783.19189.7.camel@liguang.fnst.cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1355968783.19189.7.camel@liguang.fnst.cn.fujitsu.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-mips: Use EXCP_SC rather than a magic number List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: li guang Cc: Aurelien Jarno , qemu-devel@nongnu.org, =?utf-8?B?6Zmz6Z+L5Lu7IChXZWktUmVuIENoZW4p?= , "Johnson, Eric" Hi Li, > > > Signed-off-by: Chen Wei-Ren > > > --- > > > target-mips/op_helper.c | 6 +++--- > > > 1 files changed, 3 insertions(+), 3 deletions(-) > > >=20 > > > diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c > > > index f45d494..98a445c 100644 > > > --- a/target-mips/op_helper.c > > > +++ b/target-mips/op_helper.c > > > @@ -39,10 +39,10 @@ static inline void QEMU_NORETURN do_raise_excep= tion_err(CPUMIPSState *env, > > > uintptr_t = pc) > > > { > > > TranslationBlock *tb; > > > -#if 1 > > > - if (exception < 0x100) > > > + if (exception < EXCP_SC) { > > > qemu_log("%s: %d %d\n", __func__, exception, error_code); > > > -#endif > > > + } > > > + >=20 > seems original '#if 1, #endif' statement > is for temporary debug only, > so maybe can be concealed out entirely. > for log purpose, every exception code > will log when 'do_interrupt' for MIPS > if log is enabled. Thanks for your feedback. You mean the code snippet below? --- target-mips/helper.c void do_interrupt (CPUMIPSState *env) { ... if (qemu_log_enabled() && env->exception_index !=3D EXCP_EXT_INTERRUP= T) { if (env->exception_index < 0 || env->exception_index > EXCP_LAST) name =3D "unknown"; else name =3D excp_names[env->exception_index]; qemu_log("%s enter: PC " TARGET_FMT_lx " EPC " TARGET_FMT_lx " %s= exception\n", __func__, env->active_tc.PC, env->CP0_EPC, name); } ... } Maybe we can do this way? --- diff --git a/target-mips/cpu.h b/target-mips/cpu.h index 31602ac..507a213 100644 --- a/target-mips/cpu.h +++ b/target-mips/cpu.h @@ -616,9 +616,9 @@ enum { EXCP_DSPDIS, =20 EXCP_LAST =3D EXCP_DSPDIS, + /* Dummy exception for conditional stores. */ + EXCP_SC =3D EXCP_LAST, }; -/* Dummy exception for conditional stores. */ -#define EXCP_SC 0x100 =20 /* * This is an interrnally generated WAKE request line. --- Aurelien, Johnson, thoughts? :) Regards, chenwj --=20 Wei-Ren Chen (=E9=99=B3=E9=9F=8B=E4=BB=BB) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj