From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "G.R." <firemeteor@users.sourceforge.net>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
intel-gfx@lists.freedesktop.org, "Dong,
Eddie" <eddie.dong@intel.com>,
"Xu, Dongxiao" <dongxiao.xu@intel.com>,
"Zhang, Xiantao" <xiantao.zhang@intel.com>
Subject: Re: [PATCH] Fix intel_detect_pch() to work in xen environment.
Date: Thu, 20 Dec 2012 08:13:30 -0800 [thread overview]
Message-ID: <20121220081330.19f30c3e@jbarnes-desktop> (raw)
In-Reply-To: <CAKhsbWZr4x-F+bNNN1dmH4uMahPFf_+nRUWr5B9TF-2c3_yjtQ@mail.gmail.com>
On Thu, 20 Dec 2012 12:04:11 +0800
"G.R." <firemeteor@users.sourceforge.net> wrote:
> On Wed, Dec 19, 2012 at 2:20 AM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> >> >
> >> > I'd like to see a comment about this being for Xen in here, and I
> >> > wonder if there are other places where we might have to worry about the
> >> > Xen implementation. In that case, setting a flag in dev_priv when we
> >> > don't find the PCH where we expect would be a good idea too.
> >> >
> >>
> >> I can add a comment here if the overall idea is acceptable to you.
> >> But there is already a comment mentioning that the ISA bridge check is
> >> for virtualization:
> >>
> >> 404 /*
> >> 405 * The reason to probe ISA bridge instead of Dev31:Fun0 is to
> >> 406 * make graphics device passthrough work easy for VMM, that only
> >> 407 * need to expose ISA bridge to let driver know the real hardware
> >> 408 * underneath. This is a requirement from virtualization team.
> >> 409 */
> >>
> >> > Ack on the general idea though; I'd like us to be able to run under Xen
> >> > without modification.
> >> >
> >>
> >> Stefano may be able to comment if it's feasible to achieve zero
> >> modification in this case.
> >> I believe this has something to do with getting rid of the PIIX3
> >> device provided by qemu.
> >>
> >> But generally I think it's very hard to achieve perfect emulation.
> >> You can't always foresee what assumption a guest driver would make.
> >> Maybe we need some compromise.
> >
> > I meant that I'd like to see any other patches required for Xen get
> > merged, that way people won't have to patch their kernels for i915
> > under Xen.
>
> Hi Jesse, I think I need to resend the patch with proper comment to
> have it formally accepted.
> Any guide line for formal patch submission? Do I need to start a
> separate thread?
No, just cc Daniel Vetter.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2012-12-20 16:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 16:49 [PATCH] Fix intel_detect_pch() to work in xen environment G.R.
2012-12-18 16:53 ` Jesse Barnes
2012-12-18 17:43 ` G.R.
2012-12-18 18:20 ` Jesse Barnes
2012-12-19 3:40 ` G.R.
2012-12-20 4:04 ` G.R.
2012-12-20 16:13 ` Jesse Barnes [this message]
2012-12-23 6:51 ` G.R.
2013-06-18 12:54 ` G.R.
2013-06-19 6:01 ` Daniel Vetter
2013-06-19 13:10 ` [PATCH] Fix PCH detect with multiple ISA bridges in VM Rui Guo
2013-06-19 15:29 ` [PATCH] Fix intel_detect_pch() to work in xen environment G.R.
2013-06-20 12:01 ` Daniel Vetter
2013-06-19 7:57 ` Ville Syrjälä
2012-12-18 17:21 ` Ben Widawsky
2012-12-19 4:01 ` G.R.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220081330.19f30c3e@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=dongxiao.xu@intel.com \
--cc=eddie.dong@intel.com \
--cc=firemeteor@users.sourceforge.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.