From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Kalle Valo <kvalo@adurom.com>
Cc: Gabor Juhos <juhosg@openwrt.org>,
"John W. Linville" <linville@tuxdriver.com>,
Daniel Golle <dgolle@allnet.de>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
Gertjan van Wingerde <gwingerde@gmail.com>
Subject: Re: [rt2x00-users] [PATCH 2/2] rt2x00: rt2800pci: allow to load EEPROM data via firmware API
Date: Thu, 20 Dec 2012 12:06:02 +0100 [thread overview]
Message-ID: <20121220110602.GA13055@localhost.localdomain> (raw)
In-Reply-To: <87d2y5umko.fsf@purkki.adurom.net>
On Thu, Dec 20, 2012 at 10:58:31AM +0200, Kalle Valo wrote:
> Gabor Juhos <juhosg@openwrt.org> writes:
>
> >> Since we use completion here, why we can not just use normal synchronous
> >> version of request_firmware? I heard of request_firmware drawbacks, so
> >> this approach can be correct. Just want to know if we do not complicate
> >> things not necessarily here.
> >
> > If the driver is built into the kernel, then the synchronous version
> > would fail because user-space is not up during probe time.
>
> Didn't udev/systemd guys finally fix their software? At least I recall
> seeing such claims on g+.
Udev broke and later fixed request_firmware when driver is compiled as
module. Here we avoid problem when driver is compiled into kernel
(problem which was there from very beginning) - no userspace available
so request_firmware fail. But since everyone are using modules, nobody
cares.
Openwrt must use modules too, since it use compat-wireless, right? So
I'm not sure if it worth to use request_firmware_nowait. Especially
like that with completion, which block ->probe. As long kernel does
not probes devices in parallel, we block whole boot, and deadlock since
probe wait for userspace.
Gabor, did you test your patches ?
Stanislaw
next prev parent reply other threads:[~2012-12-20 11:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 16:22 [PATCH 1/2] rt2x00: rt2800pci: verify ioremap return value Gabor Juhos
2012-12-18 16:22 ` [PATCH 2/2] rt2x00: rt2800pci: allow to load EEPROM data via firmware API Gabor Juhos
2012-12-18 22:22 ` [rt2x00-users] " Stanislaw Gruszka
2012-12-19 9:35 ` Gabor Juhos
2012-12-20 8:58 ` Kalle Valo
2012-12-20 11:06 ` Stanislaw Gruszka [this message]
2012-12-20 14:34 ` Gabor Juhos
2012-12-18 21:57 ` [rt2x00-users] [PATCH 1/2] rt2x00: rt2800pci: verify ioremap return value Stanislaw Gruszka
2012-12-19 9:34 ` Gabor Juhos
2012-12-18 23:58 ` Julian Calaby
2012-12-19 9:35 ` Gabor Juhos
2012-12-19 11:05 ` Jones Desougi
2012-12-19 11:59 ` Gabor Juhos
2013-01-07 20:02 ` John W. Linville
2013-01-07 20:37 ` Gabor Juhos
2013-01-07 21:08 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220110602.GA13055@localhost.localdomain \
--to=stf_xl@wp.pl \
--cc=dgolle@allnet.de \
--cc=gwingerde@gmail.com \
--cc=juhosg@openwrt.org \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.