From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 4/8] Thermal: Add Thermal_trip sysfs node Date: Thu, 20 Dec 2012 08:12:02 -0800 Message-ID: <20121220161202.GA29796@kroah.com> References: <1355822977-4804-1-git-send-email-durgadoss.r@intel.com> <1355822977-4804-5-git-send-email-durgadoss.r@intel.com> <20121220054201.GE28007@kroah.com> <4D68720C2E767A4AA6A8796D42C8EB5924CB6C@BGSMSX101.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-da0-f45.google.com ([209.85.210.45]:64854 "EHLO mail-da0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203Ab2LTQJC (ORCPT ); Thu, 20 Dec 2012 11:09:02 -0500 Received: by mail-da0-f45.google.com with SMTP id w4so1593945dam.32 for ; Thu, 20 Dec 2012 08:09:01 -0800 (PST) Content-Disposition: inline In-Reply-To: <4D68720C2E767A4AA6A8796D42C8EB5924CB6C@BGSMSX101.gar.corp.intel.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "R, Durgadoss" Cc: "Zhang, Rui" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "hongbo.zhang@linaro.org" , "wni@nvidia.com" On Thu, Dec 20, 2012 at 07:52:03AM +0000, R, Durgadoss wrote: > > On Tue, Dec 18, 2012 at 02:59:33PM +0530, Durgadoss R wrote: > > > This patch adds a thermal_trip directory under > > > /sys/class/thermal/zoneX. This directory contains > > > the trip point values for sensors bound to this > > > zone. > > > > Eeek, you just broke userspace tools that now can no longer see these > > entries :( > > > > Why do you need to create a subdirectory? As you found out, doing so > > isn't the easiest, right? That is on purpose. > > Yes, I observed the complexity. > > > > > I really wouldn't recommend doing this at all, please stick within the > > 'struct device' framework here, don't create new kobjects and hang sysfs > > files off of them. > > But, we cannot put all _trip directly under ZoneX directory. Why not? What is preventing this? > We can remove the thermal_trip directory, and put sensorY_trip under > /sys/class/thermal/zoneX/. But this sensorY_trip needs to be a > directory which has four sysfs nodes named, active, passive, crit, > hot. > > Rui, What do you think about this ? > > The only other way I see, is directly put sensorY_trip_[active/passive/hot/crit] > which will create way too many nodes, under /sys/class/thermal/zoneX/. What is "too many"? 20000? 50000? How many are we talking about here? What is the limiting factor that is preventing this from all going into one directory? thanks, greg k-h