From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] cgroup: remove redundant check Date: Thu, 20 Dec 2012 11:18:03 -0800 Message-ID: <20121220191803.GA14527@htj.dyndns.org> References: <1356030701-16284-1-git-send-email-sasha.levin@oracle.com> <1356030701-16284-23-git-send-email-sasha.levin@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=lYTpwQGIfsWqLGQ7uRngZhuqN+J5FfBnkNvILbLd+X0=; b=Mc5WOFHE5DTdsSRvO+NXCxcSVwSb2tjGtwuBtAsy+2OX/yAbJd6mf5qNXcFzmK2bNB 4C1SC2wvUP4ImzaV+KZDKxY+kvSx1BKEk6+mw6td+hjDfCeVNt3gVJDb7Ip4qggqM9O7 zHHwaNRzkJYGMf/ePh81zaaCcA2RIfg6phStgTsrAY1KZtxh5x63FIPDODTpTq+m+Ni4 apeQ+QZPkCruOcp12h/ezHuGxfzeYyg2kSzNtbLAg8wFuHkSNvLhwwFY4g7iTQaftlk9 GPoyYjn2yg5/PpQNY9nA5XHkyGWGX8ik3vt/lwrAE3rI+VYMt0ReedT1CpW/GNEvxfsd 9Biw== Content-Disposition: inline In-Reply-To: <1356030701-16284-23-git-send-email-sasha.levin-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sasha Levin Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu, Dec 20, 2012 at 02:11:31PM -0500, Sasha Levin wrote: > We already know that 'event' is non-NULL, remove the redundant check. > > Signed-off-by: Sasha Levin I don't know. I kinda like that test there. It's not an error path and tearing down everything which could have been allocated. If the test not being used is bothering, convert return -ENOMEM to goto fail? -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752648Ab2LTTS3 (ORCPT ); Thu, 20 Dec 2012 14:18:29 -0500 Received: from mail-ia0-f180.google.com ([209.85.210.180]:62367 "EHLO mail-ia0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752536Ab2LTTSK (ORCPT ); Thu, 20 Dec 2012 14:18:10 -0500 Date: Thu, 20 Dec 2012 11:18:03 -0800 From: Tejun Heo To: Sasha Levin Cc: Li Zefan , containers@lists.linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: remove redundant check Message-ID: <20121220191803.GA14527@htj.dyndns.org> References: <1356030701-16284-1-git-send-email-sasha.levin@oracle.com> <1356030701-16284-23-git-send-email-sasha.levin@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1356030701-16284-23-git-send-email-sasha.levin@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 20, 2012 at 02:11:31PM -0500, Sasha Levin wrote: > We already know that 'event' is non-NULL, remove the redundant check. > > Signed-off-by: Sasha Levin I don't know. I kinda like that test there. It's not an error path and tearing down everything which could have been allocated. If the test not being used is bothering, convert return -ENOMEM to goto fail? -- tejun