From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCHv4 8/8] gpu: host1x: Register DRM dummy device Date: Fri, 21 Dec 2012 15:09:35 +0100 Message-ID: <20121221140935.GB9729@avionic-0098.adnet.avionic-design.de> References: <1356089964-5265-1-git-send-email-tbergstrom@nvidia.com> <1356089964-5265-9-git-send-email-tbergstrom@nvidia.com> <1356098031.1490.111.camel@tellur> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kXdP64Ggrk/fb43R" Return-path: Content-Disposition: inline In-Reply-To: <1356098031.1490.111.camel@tellur> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lucas Stach Cc: Terje Bergstrom , airlied-cv59FeDIM0c@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org --kXdP64Ggrk/fb43R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 21, 2012 at 02:53:51PM +0100, Lucas Stach wrote: > Am Freitag, den 21.12.2012, 13:39 +0200 schrieb Terje Bergstrom: [...] > > +void host1x_unregister_drm_device(struct host1x *host1x) > > +{ > > + if (host1x->drm_device) > > + platform_device_unregister(host1x->drm_device); > > +} > > +EXPORT_SYMBOL(host1x_unregister_drm_device); > > + > > +struct platform_device *host1x_drm_device(struct platform_device *pdev) > > +{ > > + struct host1x *host = platform_get_drvdata(pdev); > > + return host->drm_device; > > +} > > +EXPORT_SYMBOL(host1x_drm_device); > This should be called host1x_get_drm_device Or maybe even host1x_drm_get_device() to make it more obvious that it doesn't return a struct drm_device. Also I think it would be better to make it take a struct device * and return a struct device * instead. Users of the API will probably call this like so: struct device *dummy = host1x_drm_get_device(pdev->dev.parent); struct drm_device *drm = dev_get_drvdata(dummy); So we save ourselves some needless up-casting. Thierry --kXdP64Ggrk/fb43R Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQ1G2fAAoJEN0jrNd/PrOh8goP/3/mlTk7KUz2hI8V5KTQrrlu v0HpANG7CrXsW9Js9fVFL4mfaKK3+x/FycRvbgZecBBYPbuSyT3LdPzsnhVZAf1Y C6hXFf66cxYLQHihAPTLqIcajYq8h4RjvtL5GdthxB6HhCAlWrv/tDdhnUZJbfD6 B1mwrgJUJga8GHvfjmolPt+xHeRxCmIKwUjNlBnki92NnIo3pyX7SILNny2UXAPi 1/kMilGOCnnKO8Q/LhFe2tSVZ1YgNlZlLOCNjuGo5E4RJHsskn4c3fnu41xxYBRp Zar1kwM8SXBVWjvCov+YbUwld8P5KhAif7fkfklzVvi1M8ylLHodApplc+CEyglW xVxSDzyTG0txQNRuivtXkdTD9DEUzkfkTx7TRI4txDhCfW3mQUF+dtLqwe3a+lGr VfEQCziTjK3uN9U7MapOB0M+EHVEOgBV0R/4H6gavZ5UvDSks4IaSMwAIicpLojp /DFgXqCKL2TyhcRT1uLbfBrJ6LAX/33haNfnsU3VYyKvo1EF5TJbdzzQ1uJE2vvi cM/x1oWqaNt32divgGHv13ctaV3eKLdG4VlnnZpcZ238JGniOis3P4l1mRRi6Xjp Q8oyK5uPdX6w4zzgOXzsAYlEsK3OIUN95laPf+7zZhYigQSooK/UEmj8ifLR5Lkq izZWjBq97PBIg/kkarC+ =aQmT -----END PGP SIGNATURE----- --kXdP64Ggrk/fb43R-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752051Ab2LUOJp (ORCPT ); Fri, 21 Dec 2012 09:09:45 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:50093 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251Ab2LUOJj (ORCPT ); Fri, 21 Dec 2012 09:09:39 -0500 Date: Fri, 21 Dec 2012 15:09:35 +0100 From: Thierry Reding To: Lucas Stach Cc: Terje Bergstrom , airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 8/8] gpu: host1x: Register DRM dummy device Message-ID: <20121221140935.GB9729@avionic-0098.adnet.avionic-design.de> References: <1356089964-5265-1-git-send-email-tbergstrom@nvidia.com> <1356089964-5265-9-git-send-email-tbergstrom@nvidia.com> <1356098031.1490.111.camel@tellur> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kXdP64Ggrk/fb43R" Content-Disposition: inline In-Reply-To: <1356098031.1490.111.camel@tellur> User-Agent: Mutt/1.5.21 (2010-09-15) X-Provags-ID: V02:K0:0VweZntXKrhgF4lsjvup30q5eob5e1r+OoCz8RyyqjD xWzL0saEY9iPsCOYMBOvhc85XJwbpywtlelevGOjD+40DJxHdz 6e7DsZuvyS8hRClfsYhGGUPAr6UvruXqS2fXLg5uA8qJRnDd2g SQupv9RqiZDsbQ+8fT8UM4nZLGbYaeAgOLPSBUr7Mu+29y/ULu iccDfZ4lS81gLfI8syeb7xM/qIOZn6C9KhF9XrfWrMSbWhFOAU qeIJLJXUCcslfX4ZUMJKUPi3mSKdLWjcnXdlGhUJWbQpKeVCXG /yyW1S7JXvwTIiCuTIsHZ3TqNWLMBF3GNkXgaVALxlPP4wJHFU oholzN98W/aJofu3GyQqlke4RvU+rQRotXC0yLT/iRu35FM+iR 01nxvshnQy4Vl8voRfWHii1pysjrT7IFLQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kXdP64Ggrk/fb43R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 21, 2012 at 02:53:51PM +0100, Lucas Stach wrote: > Am Freitag, den 21.12.2012, 13:39 +0200 schrieb Terje Bergstrom: [...] > > +void host1x_unregister_drm_device(struct host1x *host1x) > > +{ > > + if (host1x->drm_device) > > + platform_device_unregister(host1x->drm_device); > > +} > > +EXPORT_SYMBOL(host1x_unregister_drm_device); > > + > > +struct platform_device *host1x_drm_device(struct platform_device *pdev) > > +{ > > + struct host1x *host = platform_get_drvdata(pdev); > > + return host->drm_device; > > +} > > +EXPORT_SYMBOL(host1x_drm_device); > This should be called host1x_get_drm_device Or maybe even host1x_drm_get_device() to make it more obvious that it doesn't return a struct drm_device. Also I think it would be better to make it take a struct device * and return a struct device * instead. Users of the API will probably call this like so: struct device *dummy = host1x_drm_get_device(pdev->dev.parent); struct drm_device *drm = dev_get_drvdata(dummy); So we save ourselves some needless up-casting. Thierry --kXdP64Ggrk/fb43R Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQ1G2fAAoJEN0jrNd/PrOh8goP/3/mlTk7KUz2hI8V5KTQrrlu v0HpANG7CrXsW9Js9fVFL4mfaKK3+x/FycRvbgZecBBYPbuSyT3LdPzsnhVZAf1Y C6hXFf66cxYLQHihAPTLqIcajYq8h4RjvtL5GdthxB6HhCAlWrv/tDdhnUZJbfD6 B1mwrgJUJga8GHvfjmolPt+xHeRxCmIKwUjNlBnki92NnIo3pyX7SILNny2UXAPi 1/kMilGOCnnKO8Q/LhFe2tSVZ1YgNlZlLOCNjuGo5E4RJHsskn4c3fnu41xxYBRp Zar1kwM8SXBVWjvCov+YbUwld8P5KhAif7fkfklzVvi1M8ylLHodApplc+CEyglW xVxSDzyTG0txQNRuivtXkdTD9DEUzkfkTx7TRI4txDhCfW3mQUF+dtLqwe3a+lGr VfEQCziTjK3uN9U7MapOB0M+EHVEOgBV0R/4H6gavZ5UvDSks4IaSMwAIicpLojp /DFgXqCKL2TyhcRT1uLbfBrJ6LAX/33haNfnsU3VYyKvo1EF5TJbdzzQ1uJE2vvi cM/x1oWqaNt32divgGHv13ctaV3eKLdG4VlnnZpcZ238JGniOis3P4l1mRRi6Xjp Q8oyK5uPdX6w4zzgOXzsAYlEsK3OIUN95laPf+7zZhYigQSooK/UEmj8ifLR5Lkq izZWjBq97PBIg/kkarC+ =aQmT -----END PGP SIGNATURE----- --kXdP64Ggrk/fb43R--