From: Gleb Natapov <gleb@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 0/7] Fix emulate_invalid_guest_state=0 part 2
Date: Sat, 22 Dec 2012 09:05:29 +0200 [thread overview]
Message-ID: <20121222070529.GU29007@redhat.com> (raw)
In-Reply-To: <20121221235529.GB30710@amt.cnet>
On Fri, Dec 21, 2012 at 09:55:29PM -0200, Marcelo Tosatti wrote:
> On Wed, Dec 12, 2012 at 07:10:48PM +0200, Gleb Natapov wrote:
> > emulate_invalid_guest_state=0 still does not work since last patch of
> > my previous series was not applied. It causes kvm to emulate code that
> > previously kvm managed to run in vm86 and this, in turn, causes emulation
> > errors for instructions kvm does not know how to emulate. Patch 2 of
> > the series should fix that. Patch 3 is exactly same as 4/4 from previous
> > series. Other patches are clean-ups.
>
> Can't see how guest_state_valid() can affect
> emulate_invalid_guest_state=0.
>
Patch 3/7 fixes it. Patch 2/7 is needed for 3/7 to not break
emulate_invalid_guest_state=1.
> For the cleanups, Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com>.
--
Gleb.
prev parent reply other threads:[~2012-12-22 7:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 17:10 [PATCH 0/7] Fix emulate_invalid_guest_state=0 part 2 Gleb Natapov
2012-12-12 17:10 ` [PATCH 1/7] KVM: VMX: cleanup rmode_segment_valid() Gleb Natapov
2012-12-12 17:10 ` [PATCH 2/7] KVM: VMX: relax check for CS register in rmode_segment_valid() Gleb Natapov
2012-12-21 23:17 ` Marcelo Tosatti
2012-12-22 7:02 ` Gleb Natapov
2012-12-22 14:55 ` Marcelo Tosatti
2012-12-22 14:58 ` Marcelo Tosatti
2012-12-12 17:10 ` [PATCH 3/7] KVM: VMX: return correct segment limit and flags for CS/SS registers in real mode Gleb Natapov
2012-12-12 17:10 ` [PATCH 4/7] KVM: VMX: use fix_rmode_seg() to fix all code/data segments Gleb Natapov
2012-12-12 17:10 ` [PATCH 5/7] KVM: VMX: remove redundant code from vmx_set_segment() Gleb Natapov
2012-12-12 17:10 ` [PATCH 6/7] KVM: VMX: clean-up vmx_set_segment() Gleb Natapov
2012-12-12 17:10 ` [PATCH 7/7] KVM: VMX: remove unneeded temporary variable from vmx_set_segment() Gleb Natapov
2012-12-21 23:55 ` [PATCH 0/7] Fix emulate_invalid_guest_state=0 part 2 Marcelo Tosatti
2012-12-22 7:05 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121222070529.GU29007@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.