From: Solomon Peachy <pizza@shaftnet.org>
To: Pontus Fuchs <pontus.fuchs@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 06/17] cw1200: Mini-AP implementation
Date: Sat, 22 Dec 2012 17:34:34 -0500 [thread overview]
Message-ID: <20121222223434.GH5120@shaftnet.org> (raw)
In-Reply-To: <50D61117.8020009@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]
On Sat, Dec 22, 2012 at 08:59:19PM +0100, Pontus Fuchs wrote:
> I remember fixing a tricky bug here. When loosing BSS the driver can
> in some case leave
> priv->bss_loss_status to > CW1200_BSS_LOSS_NONE.
> This blocks further processing of the BSS_LOST events from firmware
> causing link loss detection to fail.
>
> The fix was to clean up bss_lost_status here before canceling
> bss_loss_work and connection_loss_work:
>
> priv->delayed_link_loss = 0;
> spin_lock(&priv->bss_loss_lock);
> priv->bss_loss_status = CW1200_BSS_LOSS_NONE;
> spin_unlock(&priv->bss_loss_lock);
>
> >+ cancel_delayed_work_sync(&priv->bss_loss_work);
> >+ cancel_delayed_work_sync(&priv->connection_loss_work);
> >+#endif /* CONFIG_CW1200_USE_STE_EXTENSIONS */
The code you're referencing is partially wrapped in STE_EXTENSIONS --
and most of that refers to stuff that wasn't ever part of mac80211.
So I pulled the work cancellation out of the STE_EXTENSION wrapper and
prepended that code you suggested.
I'm finally done auditing and (mostly) purging all the STE_EXTENSIONS
stuff, so I'll be submitting another patch series shortly that
incorporates everything suggested so far.
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Melbourne, FL ^^ (mail/jabber/gtalk) ^^
Quidquid latine dictum sit, altum viditur.
[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2012-12-22 22:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 15:45 RFC: Driver ST-E cw1200 driver Solomon Peachy
2012-12-22 15:45 ` [PATCH 01/17] cw1200: Low-level hardware I/O functions Solomon Peachy
2012-12-22 15:45 ` [PATCH 02/17] cw1200: Internal tx queue tracking and handling Solomon Peachy
2012-12-22 15:45 ` [PATCH 03/17] cw1200: Scan implementation Solomon Peachy
2012-12-22 15:45 ` [PATCH 04/17] cw1200: Power management (ie psuedo-WoWLAN) Solomon Peachy
2012-12-22 15:45 ` [PATCH 05/17] cw1200: Firmware loading code Solomon Peachy
2012-12-22 15:45 ` [PATCH 06/17] cw1200: Mini-AP implementation Solomon Peachy
2012-12-22 19:59 ` Pontus Fuchs
2012-12-22 21:22 ` Solomon Peachy
2012-12-22 22:34 ` Solomon Peachy [this message]
[not found] ` <CAM8CFPgJu5CR9tU_mMw1_0yDUEj-dLk2G+6W91W1-H4LMa+BUw@mail.gmail.com>
2012-12-23 12:47 ` Solomon Peachy
[not found] ` <CAM8CFPj==UdTjCe0=hPRtT_BC1E4TvRFDjqBZUD4=c+PbkncVA@mail.gmail.com>
2012-12-23 16:44 ` Solomon Peachy
2012-12-27 8:48 ` Kalle Valo
2012-12-27 14:07 ` Solomon Peachy
2012-12-22 15:45 ` [PATCH 07/17] cw1200: debuging hooks (using debugfs) Solomon Peachy
2012-12-22 15:45 ` [PATCH 08/17] cw1200: Optional Hooks for one of ST-E's testing tools Solomon Peachy
2012-12-22 15:45 ` [PATCH 09/17] cw1200: 802.11 STA API Solomon Peachy
2012-12-22 15:45 ` [PATCH 10/17] cw1200: Packet transmit and receive handling Solomon Peachy
2012-12-22 15:45 ` [PATCH 11/17] cw1200: WSM (ie host-firmware) host interface Solomon Peachy
2012-12-22 15:45 ` [PATCH 12/17] cw1200: Main processing loop Solomon Peachy
2012-12-22 15:45 ` [PATCH 13/17] cw1200: common registration/setup code Solomon Peachy
2012-12-22 15:45 ` [PATCH 14/17] cw1200: driver state and definitions Solomon Peachy
2012-12-22 15:45 ` [PATCH 15/17] cw1200: SDIO and SPI glue code, plus platform data Solomon Peachy
2012-12-22 15:45 ` [PATCH 16/17] cw1200: Integration into the kernel build system Solomon Peachy
2012-12-22 20:19 ` Johannes Berg
2012-12-22 20:32 ` Solomon Peachy
2012-12-22 15:45 ` [PATCH 17/17] cw1200: Integrate into staging tree Solomon Peachy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121222223434.GH5120@shaftnet.org \
--to=pizza@shaftnet.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pontus.fuchs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.