From: Simon Horman <horms@verge.net.au>
To: Daniel Mack <zonque@gmail.com>
Cc: Sven Neumann <neumann@teufel.de>,
kexec@lists.infradead.org, Stephen Warren <swarren@nvidia.com>,
Eric Biederman <ebiederm@xmission.com>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH] kexec-zImage-arm: simply cmdline-related DTB resizing
Date: Sun, 23 Dec 2012 16:14:44 +0900 [thread overview]
Message-ID: <20121223071440.GM26088@verge.net.au> (raw)
In-Reply-To: <50D27175.7030006@gmail.com>
On Thu, Dec 20, 2012 at 10:01:25AM +0800, Daniel Mack wrote:
> On 12/20/2012 07:19 AM, Stephen Warren wrote:
> > From: Stephen Warren <swarren@nvidia.com>
> >
> > When resizing a dtb to add the command-line, only resize the DTB once,
> > rather than once to add the /chosen node, and once to add the bootargs
> > property.
> >
> > Also, simply add 1K of overhead (beyond strlen(cmdline)) to the buffer,
> > to avoid requiring precise knowledge of the size impact of the requested
> > FTB changes. In particular, some padding is performed when setting
> > property values, which was not accounted for in the current code, which
> > caused failures to set the bootargs values in some cases.
> >
> > Cc: Daniel Mack <zonque@gmail.com>
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2012-12-23 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 23:19 [PATCH] kexec-zImage-arm: simply cmdline-related DTB resizing Stephen Warren
2012-12-20 2:01 ` Daniel Mack
2012-12-23 7:14 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121223071440.GM26088@verge.net.au \
--to=horms@verge.net.au \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=neumann@teufel.de \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.