diff for duplicates of <20121223231547.GA2453@blaptop> diff --git a/a/1.txt b/N1/1.txt index 169b92f..5140f1b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ On Fri, Dec 21, 2012 at 01:46:23PM +0100, Michal Nazarewicz wrote: > > On Thu, Dec 20, 2012 at 04:49:44PM +0100, Michal Nazarewicz wrote: -> >> Perhaps a??is_migrate_isolatea?? to match already existing a??is_migrate_cmaa??? +> >> Perhaps “is_migrate_isolate” to match already existing “is_migrate_cma”? > > On Fri, Dec 21 2012, Minchan Kim wrote: > > Good poking. In fact, while I made this patch, I was very tempted by renaming @@ -16,7 +16,7 @@ On Fri, Dec 21, 2012 at 01:46:23PM +0100, Michal Nazarewicz wrote: > > It's very clear for me because migratetype is per pageblock, we can know the > > function works per pageblock unit. > > -> >> Especially as the a??mt_isolated_pageblocka?? sound confusing to me, it +> >> Especially as the “mt_isolated_pageblock” sound confusing to me, it > >> implies that it works on pageblocks which it does not. > > > > -ENOPARSE. @@ -26,7 +26,7 @@ On Fri, Dec 21, 2012 at 01:46:23PM +0100, Michal Nazarewicz wrote: > migratetype is a number, which can be assigned to a pageblock. In some > transitional cases, the migratetype associated with a page can differ > from the migratetype associated with the pageblock the page is in. As -> such, I think it's confusing to add a??pageblocka?? to the name of the +> such, I think it's confusing to add “pageblock” to the name of the > function which does not read migratetype from pageblock but rather > operates on the number it is provided. @@ -36,8 +36,8 @@ Fair enough. > > I admit mt is really dirty but I used page_alloc.c already has lots of > > mt, SIGH. > -> I don't really have an issue with a??mta?? myself, especially since the few -> times a??mta?? is used in page_alloc.c it is a local variable which I don't +> I don't really have an issue with “mt” myself, especially since the few +> times “mt” is used in page_alloc.c it is a local variable which I don't > think needs a long descriptive name since context is all there. > > > How about this? @@ -57,7 +57,7 @@ Thanks for the review, Michal. > -- > Best regards, _ _ > .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o -> ..o | Computer Science, MichaA? a??mina86a?? Nazarewicz (o o) +> ..o | Computer Science, Michał “mina86” Nazarewicz (o o) > ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo-- @@ -67,9 +67,3 @@ Thanks for the review, Michal. -- Kind regards, Minchan Kim - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index d788874..1bc3991 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -13,7 +13,7 @@ "b\0" "On Fri, Dec 21, 2012 at 01:46:23PM +0100, Michal Nazarewicz wrote:\n" "> > On Thu, Dec 20, 2012 at 04:49:44PM +0100, Michal Nazarewicz wrote:\n" - "> >> Perhaps a??is_migrate_isolatea?? to match already existing a??is_migrate_cmaa???\n" + "> >> Perhaps \342\200\234is_migrate_isolate\342\200\235 to match already existing \342\200\234is_migrate_cma\342\200\235?\n" "> \n" "> On Fri, Dec 21 2012, Minchan Kim wrote:\n" "> > Good poking. In fact, while I made this patch, I was very tempted by renaming\n" @@ -29,7 +29,7 @@ "> > It's very clear for me because migratetype is per pageblock, we can know the\n" "> > function works per pageblock unit.\n" "> >\n" - "> >> Especially as the a??mt_isolated_pageblocka?? sound confusing to me, it\n" + "> >> Especially as the \342\200\234mt_isolated_pageblock\342\200\235 sound confusing to me, it\n" "> >> implies that it works on pageblocks which it does not.\n" "> >\n" "> > -ENOPARSE.\n" @@ -39,7 +39,7 @@ "> migratetype is a number, which can be assigned to a pageblock. In some\n" "> transitional cases, the migratetype associated with a page can differ\n" "> from the migratetype associated with the pageblock the page is in. As\n" - "> such, I think it's confusing to add a??pageblocka?? to the name of the\n" + "> such, I think it's confusing to add \342\200\234pageblock\342\200\235 to the name of the\n" "> function which does not read migratetype from pageblock but rather\n" "> operates on the number it is provided.\n" "\n" @@ -49,8 +49,8 @@ "> > I admit mt is really dirty but I used page_alloc.c already has lots of\n" "> > mt, SIGH.\n" "> \n" - "> I don't really have an issue with a??mta?? myself, especially since the few\n" - "> times a??mta?? is used in page_alloc.c it is a local variable which I don't\n" + "> I don't really have an issue with \342\200\234mt\342\200\235 myself, especially since the few\n" + "> times \342\200\234mt\342\200\235 is used in page_alloc.c it is a local variable which I don't\n" "> think needs a long descriptive name since context is all there.\n" "> \n" "> > How about this?\n" @@ -70,7 +70,7 @@ "> -- \n" "> Best regards, _ _\n" "> .o. | Liege of Serenely Enlightened Majesty of o' \\,=./ `o\n" - "> ..o | Computer Science, MichaA? a??mina86a?? Nazarewicz (o o)\n" + "> ..o | Computer Science, Micha\305\202 \342\200\234mina86\342\200\235 Nazarewicz (o o)\n" "> ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--\n" "\n" "\n" @@ -79,12 +79,6 @@ "\n" "-- \n" "Kind regards,\n" - "Minchan Kim\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + Minchan Kim -df615b4d5dbfb0783fc5ac13be4b5f319d2c731195607c37e6d3f06db6092534 +8bfe8b7d7456fdc967baadaac3ba9227fbde8231a0a168a6da36c6632e6322f0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.