From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, dong.aisheng@linaro.org,
eric.nelson@boundarydevices.com
Subject: Re: [PATCH] ASoC: Fix maximum value for microphone gain
Date: Mon, 24 Dec 2012 15:29:14 +0000 [thread overview]
Message-ID: <20121224152914.GA30837@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1356284479-19323-1-git-send-email-festevam@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 701 bytes --]
On Sun, Dec 23, 2012 at 03:41:19PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> sgtl5000 microphone gain only has 2 bits of resolution, so maximum value is 3.
>
> From Eric Nelson:
> "We also found that for the microphones we have here (commodity PC boom mics) a
> default value of 2 for the gain gives the best results."
>
> So change the default microphone gain as well.
The first bit is fine but the default change is not generally the sort
of thing we do in ASoC - we generally go with the chip defaults, it
saves on going round in circles arguing about what the defaults should
be. Why would other systems not want a different default?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-12-24 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-23 17:41 [PATCH] ASoC: Fix maximum value for microphone gain Fabio Estevam
2012-12-24 15:29 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121224152914.GA30837@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dong.aisheng@linaro.org \
--cc=eric.nelson@boundarydevices.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.