From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, dong.aisheng@linaro.org,
eric.nelson@boundarydevices.com
Subject: Re: [PATCH v2] ASoC: sgtl5000: Fix maximum value for microphone gain
Date: Mon, 24 Dec 2012 15:31:47 +0000 [thread overview]
Message-ID: <20121224153146.GB30837@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1356284731-19380-1-git-send-email-festevam@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 423 bytes --]
On Sun, Dec 23, 2012 at 03:45:31PM -0200, Fabio Estevam wrote:
> - snd_soc_write(codec, SGTL5000_CHIP_MIC_CTRL, 0);
> + snd_soc_write(codec, SGTL5000_CHIP_MIC_CTRL, 2);
Hrm, on second thoughts I see we're already changing the default so I
applied this but we really should just change the driver to leave the
device with whatever setting it powers on with - this is an example of
the sort of thing we're trying to avoid.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-12-24 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-23 17:45 [PATCH v2] ASoC: sgtl5000: Fix maximum value for microphone gain Fabio Estevam
2012-12-24 15:31 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121224153146.GB30837@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dong.aisheng@linaro.org \
--cc=eric.nelson@boundarydevices.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.