Re: [Powertop] [RFC] [PATCHv2 00/10] Code deduplication in cpu/*

[Sergey Senozhatsky <sergey.senozhatsky at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

On (12/24/12 03:08), Ivan Shapovalov wrote:
> This is a resend (unchanged but rebased) of the patch series about refactoring code
> in cpu/* by deduplication. From this series, only the last bugfix patch has been applied
> so far due to a code freeze.
> 
> Ivan Shapovalov (10):
>       Fix includes: do not include intel_cpus.h inside cpu.h
>       Deduplication: move is_turbo() function to lib
>       Deduplication: move all instances of account_freq() to abstract_cpu::account_freq()
>       Deduplication: remove nhm_cpu::account_freq() almost identical to abstract_cpu::account_freq()
>       Deduplication: remove nhm_{cpu,core,package}::change_effective_frequency() identical to cpu_{linux,core,package}::change_effective_frequency()
>       Deduplication: merge cpu_{core,linux,package}::change_effective_frequency() into abstract_cpu::change_effective_frequency()
>       Deduplication: remove {cpu,nhm}_core::calculate_freq() identical to abstract_cpu::calculate_freq()
>       Deduplication: remove nhm_package::calculate_freq() identical to cpu_package::calculate_freq()
>       Deduplication: properly merge cpu_package::calculate_freq() into abstract_cpu::calculate_freq()
>       Deduplication: merge go_idle()/go_unidle()/change_freq() overrides into abstract_cpu() class
> 

Hello Chris,
patch series looks good to me. thanks to Ivan.

please note V3 of 02 and 03 patches.


	-ss