From: Evgeniy Polyakov <zbr@ioremap.net>
To: david <david@avoncliff.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] resubmit w1_therm:Retries:remove old code add CRC
Date: Mon, 24 Dec 2012 22:47:35 +0400 [thread overview]
Message-ID: <20121224184735.GA4143@ioremap.net> (raw)
In-Reply-To: <50CFC8F4.60601@avoncliff.com>
Hi
Sorry for late reply - too much things to finish before the new year.
On Tue, Dec 18, 2012 at 01:37:56AM +0000, david (david@avoncliff.com) wrote:
> w1_therm includes some obsolete code to detect bad_roms, this is no
> longer relevant.
> The retry code is only used for this bad_rom test, however there is a
> CRC check that detects a bad read, but does not trigger a retry. This
> patch removes all the bad_rom code and uses the CRC check to trigger
> retries.
>
> Signed-off-by: David Stevenson <david@avoncliff.com>
Greg, patch is ok, we discussed it in private with David
Please push it into your tree
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
--
Evgeniy Polyakov
prev parent reply other threads:[~2012-12-24 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 1:37 [PATCH] resubmit w1_therm:Retries:remove old code add CRC david
2012-12-24 18:47 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121224184735.GA4143@ioremap.net \
--to=zbr@ioremap.net \
--cc=david@avoncliff.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.