All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Overstreet <koverstreet@google.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: Zach Brown <zab@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/26] aio: remove retry-based AIO
Date: Wed, 26 Dec 2012 15:31:41 -0800	[thread overview]
Message-ID: <20121226233141.GC20185@google.com> (raw)
In-Reply-To: <CAJd=RBBAcZXKZZSrMuzm963ie81oGjHzYgyogtr2SPW2E0E_0w@mail.gmail.com>

On Wed, Dec 19, 2012 at 08:04:11PM +0800, Hillf Danton wrote:
> >@@ -52,15 +46,6 @@ struct kioctx;
> >  * not ask the method again -- ki_retry must ensure forward progress.
> >  * aio_complete() must be called once and only once in the future, multiple
> >  * calls may result in undefined behaviour.
> >- *
> >- * If ki_retry returns -EIOCBRETRY it has made a promise that kick_iocb()
> >- * will be called on the kiocb pointer in the future.  This may happen
> >- * through generic helpers that associate kiocb->ki_wait with a wait
> >- * queue head that ki_retry uses via current->io_wait.  It can also happen
> >- * with custom tracking and manual calls to kick_iocb(), though that is
> >- * discouraged.  In either case, kick_iocb() must be called once and only
> >- * once.  ki_retry must ensure forward progress, the AIO core will wait
> >- * indefinitely for kick_iocb() to be called.
> >  */
> > struct kiocb {
> > 	struct list_head	ki_run_list;
> 
> Then you can also erase ki_run_list if no longer used.

Thanks, fixed that and also the comments you pointed out.

  reply	other threads:[~2012-12-26 23:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-19 12:04 [PATCH 04/26] aio: remove retry-based AIO Hillf Danton
2012-12-26 23:31 ` Kent Overstreet [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-12-03 20:58 [PATCH 00/26] AIO performance improvements/cleanups, v2 Kent Overstreet
2012-12-03 20:58 ` [PATCH 04/26] aio: remove retry-based AIO Kent Overstreet
2012-12-03 20:58   ` Kent Overstreet
2012-12-27 10:11   ` Fubo Chen
2012-12-27 10:11     ` Fubo Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121226233141.GC20185@google.com \
    --to=koverstreet@google.com \
    --cc=dhillf@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.