All of lore.kernel.org
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect
Date: Thu, 27 Dec 2012 08:21:55 +0100	[thread overview]
Message-ID: <201212270821.55253.marex@denx.de> (raw)
In-Reply-To: <1356591603-23323-4-git-send-email-peter.chen@freescale.com>

Dear Peter Chen,

[...]
> +
> +#define CI_VBUS_STABLE_TIMEOUT 500

Shall we not change this to static const int instead ?

[...]

> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1371,6 +1371,7 @@ static int ci13xxx_vbus_session(struct usb_gadget
> *_gadget, int is_active) pm_runtime_get_sync(&_gadget->dev);
>  			hw_device_reset(ci, USBMODE_CM_DC);
>  			hw_device_state(ci, ci->ep0out->qh.dma);
> +			dev_dbg(ci->dev, "Connected to host\n");
>  		} else {
>  			hw_device_state(ci, 0);
>  			if (ci->platdata->notify_event)
> @@ -1378,6 +1379,7 @@ static int ci13xxx_vbus_session(struct usb_gadget
> *_gadget, int is_active) CI13XXX_CONTROLLER_STOPPED_EVENT);
>  			_gadget_stop_activity(&ci->gadget);
>  			pm_runtime_put_sync(&_gadget->dev);
> +			dev_dbg(ci->dev, "disconnected from host\n");

Keep the capital letters at the begining of the sentence consistent -- either 
start with capital D here or fix the capital C above.

>  		}
>  	}

  reply	other threads:[~2012-12-27  7:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-27  6:59 [PATCH v4 0/7] Add fully tested id switch and vbus connect detect support for Chipidea Peter Chen
2012-12-27  6:59 ` [PATCH v4 1/7] Revert "USB: chipidea: add vbus detect for udc" Peter Chen
2012-12-27  6:59 ` [PATCH v4 2/7] usb: chipidea: add otg file Peter Chen
2012-12-27 10:47   ` Sascha Hauer
2012-12-28  2:14     ` Peter Chen
2012-12-27  6:59 ` [PATCH v4 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect Peter Chen
2012-12-27  7:21   ` Marek Vasut [this message]
2012-12-27  8:20     ` Peter Chen
2012-12-27  8:31       ` Marek Vasut
2012-12-27  7:00 ` [PATCH v4 4/7] usb: chipidea: consolidate ci_role_driver's API for both roles Peter Chen
2012-12-27  7:00 ` [PATCH v4 5/7] usb: chipidea: udc: add pullup/pulldown dp at hw_device_state Peter Chen
2012-12-27  7:00 ` [PATCH v4 6/7] usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS Peter Chen
2012-12-27  7:00 ` [PATCH v4 7/7] usb: chipidea: imx: add internal vbus regulator control Peter Chen
2013-01-08 15:27 ` [PATCH v4 0/7] Add fully tested id switch and vbus connect detect support for Chipidea Maxime Ripard
2013-01-09  3:23   ` Peter Chen
2013-01-09 11:43     ` Maxime Ripard
2013-01-10  1:38       ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201212270821.55253.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.