From: Theodore Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Zheng Liu <gnehzuil.liu@gmail.com>,
Alexander Beregalov <a.beregalov@gmail.com>,
linux-ext4@vger.kernel.org
Subject: Re: 3.8.0-rc1: WARNING: at fs/ext4/page-io.c:232
Date: Thu, 27 Dec 2012 08:44:13 -0500 [thread overview]
Message-ID: <20121227134413.GA20671@thunk.org> (raw)
In-Reply-To: <87mwwzq5t7.fsf@openvz.org>
On Thu, Dec 27, 2012 at 12:04:36PM +0400, Dmitry Monakhov wrote:
> In fact this is my fault that we still not have autotest for that.
> I'm think of add crash-test to xfstests which should trigger journal
> abort and forced umount. Later test should mount FS which trigger
> journal_replay and orphan_cleanup.
We could create some tests in xfstests which force a crash via "echo b
> /proc/sysrq-trigger", but the trick is would require xfstests to
install something in the /etc/rc scripts so xfstests could resume
right after it came back --- and perhaps to echo something to the
console which automated test runners (such as the one I use which I've
published at [1] could capture so they would know that they should
restart the system.
[1] git://git.kernel.org/pub/scm/fs/ext2/xfstests-bld.git
For now the simplest way to test this is to use the file system image
in tests/f_orphan_extents_inode/image.gz, and make this be an
ext4-specific test. This is how I tested it when I created my fix (in
parallel with Zheng's patch). The compressed file system image is
only 564 bytes --- and was made deliberately w/o a journal so it could
be that small --- and the lack of a journal was how I found the
infinite loop problem which was fixed in the 2/2 patch in my patches.
So including this compressed fs image in xfstests is probably the way
I would suggest for now.
- Ted
next prev parent reply other threads:[~2012-12-27 13:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 0:27 3.8.0-rc1: WARNING: at fs/ext4/page-io.c:232 Alexander Beregalov
2012-12-27 6:29 ` Zheng Liu
2012-12-27 8:04 ` Dmitry Monakhov
2012-12-27 10:33 ` Zheng Liu
2012-12-27 13:44 ` Theodore Ts'o [this message]
2012-12-29 0:21 ` Dave Chinner
2012-12-29 5:04 ` Dmitry Monakhov
2012-12-29 23:23 ` Dave Chinner
2013-01-02 15:17 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121227134413.GA20671@thunk.org \
--to=tytso@mit.edu \
--cc=a.beregalov@gmail.com \
--cc=dmonakhov@openvz.org \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.