From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40319)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Tog7t-0003qT-Pp
	for qemu-devel@nongnu.org; Fri, 28 Dec 2012 15:01:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Tog7s-0003LU-VA
	for qemu-devel@nongnu.org; Fri, 28 Dec 2012 15:01:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:24061)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Tog7s-0003LN-Mf
	for qemu-devel@nongnu.org; Fri, 28 Dec 2012 15:01:52 -0500
Date: Fri, 28 Dec 2012 21:01:47 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20121228210147.59259706@thinkpad.mammed.net>
In-Reply-To: <20121228173919.GA3321@otherpad.lan.raisama.net>
References: <1356620376-23501-1-git-send-email-imammedo@redhat.com>
	<1356620376-23501-11-git-send-email-imammedo@redhat.com>
	<20121228173919.GA3321@otherpad.lan.raisama.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/20] target-i386: replace uint32_t vendor
 fields by vendor string in x86_def_t
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, afaerber@suse.de

On Fri, 28 Dec 2012 15:39:19 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:

> On Thu, Dec 27, 2012 at 03:59:26PM +0100, Igor Mammedov wrote:
> [...]
> >      assert(kvm_enabled());
> >  
> >      x86_cpu_def->name = "host";
> > -    host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx);
> > -    x86_cpu_def->vendor1 = ebx;
> > -    x86_cpu_def->vendor2 = edx;
> > -    x86_cpu_def->vendor3 = ecx;
> > +    x86cpu_vendor_words2str(x86_cpu_def->vendor, ebx, edx, ecx);
> 
> Oops: you removed the host_cpuid() call by mistake, so now we're filling
> the vendor string with zeroes.
fixed in v4 series

Thanks!

> 
> Reviewed-by withdrawn.
> 
> -- 
> Eduardo


-- 
Regards,
  Igor