From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging:iio:adis16260: select IIO_ADIS_LIB to fix build error
Date: Mon, 31 Dec 2012 15:24:26 +0800 [thread overview]
Message-ID: <20121231072426.GT11568@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <50E13BBA.1000801@metafoo.de>
On Mon, Dec 31, 2012 at 08:16:10AM +0100, Lars-Peter Clausen wrote:
> On 12/31/2012 06:36 AM, Yuanhan Liu wrote:
> > Commit 9d5e9fdf turned the code to use adis library, so it depends on
> > adis lib. But it forgot to select it at Kconfig file. Thus if adis is
> > not enabled, it will produce following build errros(catched by Fengguang's
> > 0-DAY kernel build testing system):
> > ERROR: "adis_initial_startup" [drivers/staging/iio/gyro/adis16260.ko] undefined!
> > ERROR: "adis_init" [drivers/staging/iio/gyro/adis16260.ko] undefined!
> > ERROR: "adis_write_reg" [drivers/staging/iio/gyro/adis16260.ko] undefined!
> > ERROR: "adis_read_reg" [drivers/staging/iio/gyro/adis16260.ko] undefined!
> > ERROR: "adis_single_conversion" [drivers/staging/iio/gyro/adis16260.ko] undefined!
> >
> > Selecting IIO_ADIS_LIB at Kconfig file fixes this issue.
> >
> > Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> > Cc: Lars-Peter Clausen <lars@metafoo.de>
> > Cc: Jonathan Cameron <jic23@kernel.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> Hi,
>
> Thanks. But I already sent a similar patch some time ago. See
> http://www.spinics.net/lists/linux-iio/msg07128.html
Got it, and sorry for the duplicate patch.
--yliu
prev parent reply other threads:[~2012-12-31 7:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 5:36 [PATCH] staging:iio:adis16260: select IIO_ADIS_LIB to fix build error Yuanhan Liu
2012-12-31 7:16 ` Lars-Peter Clausen
2012-12-31 7:24 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121231072426.GT11568@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.